From: Patrick Williams <patrick@stwcx.xyz>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/6] Add documentation for merged defconfigs
Date: Tue, 5 Jul 2016 17:41:04 -0500 [thread overview]
Message-ID: <20160705224104.GD20922@asimov.austin.ibm.com> (raw)
In-Reply-To: <1467756823.4917.1.camel@mendozajonas.com>
On Wed, Jul 06, 2016 at 08:13:43AM +1000, Samuel Mendoza-Jonas wrote:
> On Tue, 2016-07-05 at 14:32 -0500, Patrick Williams wrote:
> > On Fri, Jul 01, 2016 at 03:18:58PM +0200, Romain Naour wrote:
> > > Hi Sam,
> > >
> > > This series has been discussed with other developers and we concluded that this
> > > feature is not the responsibility of Buildroot to generate a defconfig from
> > > partial configuration files.
> > >
> > > Instead we recommend to use merge_config.sh from outside of Buildroot to
> > > generate the merged defconfig before calling make. Maybe we should add some
> > > documentation in the manual to explain how to use it.
> > >
> > > Best regards,
> > > Romain
> > >
> >
> > Earlier we had two independent patch sets that we were asked to merge.
> >
> > 1) Merged defconfigs (now this patch set).
> > 2) Subdirs for defconfigs.
> >
> > If #1 has been rejected as undesireable, should we now prepare an
> > indepenent patch set for #2 or is that also not wanted now?
> >
> > There is currently no way for us to manage this behavior in a
> > BR2_EXTERNAL layer alone because there is no Makefile from the
> > BR2_EXTERNAL path sourced in the defconfig case. Is there any issue
> > with a patch that will source a file like $(BR2_EXTERNAL)/external-defconfig.mk?
>
> Actually there might be - Sam was telling me yesterday that the main
> Makefile includes?$(BR2_EXTERNAL)/external.mk, which is something we may
> use to get mergeconfigs in op-build. That might work for nested configs
> as well.
>
I've already been down this route. The 'include
$(BR2_EXTERNAL)/external.mk' is inside a big 'ifeq
($(BR2_HAVE_DOT_CONFIG),y)' on line 336. That effectively means if you
don't already have a .config (which comes about from running a
'defconfig' recipe) then you don't get a source to external.mk. That is
why I'm asking about a new 'external-defconfig.mk'.
> >
> > I realize we could have a new script, but we already have users that are
> > use to 'make <system>_defconfig && make' so we would like to be able to
> > preserve that behavior even though we are moving to merged defconfig
> > fragments.
> >
>
--
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160705/d32d6c33/attachment.asc>
next prev parent reply other threads:[~2016-07-05 22:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 5:06 [Buildroot] [PATCH v3 0/6] Makefile: Support merged and nested defconfigs Sam Bobroff
2016-06-29 5:06 ` [Buildroot] [PATCH v3 1/6] Add support for merged defconfigs Sam Bobroff
2016-07-01 8:47 ` Romain Naour
2016-07-05 5:44 ` Sam Bobroff
2016-06-29 5:06 ` [Buildroot] [PATCH v3 2/6] Add documentation " Sam Bobroff
2016-07-01 13:18 ` Romain Naour
2016-07-05 6:06 ` Sam Bobroff
2016-07-05 6:16 ` Thomas Petazzoni
2016-07-06 3:35 ` Sam Bobroff
2016-07-05 19:32 ` Patrick Williams
2016-07-05 22:13 ` Samuel Mendoza-Jonas
2016-07-05 22:41 ` Patrick Williams [this message]
2016-07-06 19:08 ` Romain Naour
2016-07-06 20:56 ` Yann E. MORIN
2016-06-29 5:06 ` [Buildroot] [PATCH v3 3/6] Makefile: Generate %_defconfig recipes from macro Sam Bobroff
2016-06-29 5:06 ` [Buildroot] [PATCH v3 4/6] Makefile: Support nested config directories Sam Bobroff
2016-06-29 5:06 ` [Buildroot] [PATCH v3 5/6] Makefile: Add nested config dirs to list-defconfigs Sam Bobroff
2016-06-29 5:06 ` [Buildroot] [PATCH v3 6/6] Makefile: Add merged defconfigs " Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705224104.GD20922@asimov.austin.ibm.com \
--to=patrick@stwcx.xyz \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox