From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python-pillow: fix wrong install step
Date: Wed, 6 Jul 2016 14:46:23 +0200 [thread overview]
Message-ID: <20160706144623.4015111f@free-electrons.com> (raw)
In-Reply-To: <1467756127-30393-1-git-send-email-angelo.compagnucci@gmail.com>
Hello,
On Wed, 6 Jul 2016 00:02:07 +0200, Angelo Compagnucci wrote:
> -PYTHON_PILLOW_INSTALL_TARGET_CMDS = $(PYTHON_PILLOW_BUILD_CMDS) install
> +PYTHON_PILLOW_INSTALL_TARGET_CMDS = cd $(PYTHON_PILLOW_BUILDDIR); \
> + $(PYTHON_PILLOW_BASE_ENV) $(PYTHON_PILLOW_ENV) \
> + $(PYTHON_PILLOW_PYTHON_INTERPRETER) setup.py build_ext \
What are you doing the build_ext target again here?
> + $(PYTHON_PILLOW_BUILD_OPTS) install \
> + $(PYTHON_PILLOW_BASE_INSTALL_TARGET_OPTS) \
> + $(PYTHON_PILLOW_INSTALL_TARGET_OPTS)
Also, please use define ... endef for those commands (ditto for the
build command, I missed that when applying the patch).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-06 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 22:02 [Buildroot] [PATCH] package/python-pillow: fix wrong install step Angelo Compagnucci
2016-07-06 12:46 ` Thomas Petazzoni [this message]
2016-07-06 12:51 ` Angelo Compagnucci
2016-07-06 13:05 ` Thomas Petazzoni
2016-07-06 13:09 ` Angelo Compagnucci
2016-07-06 13:15 ` Thomas Petazzoni
2016-07-06 13:17 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706144623.4015111f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox