From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] openblas: add an option to install tests on the target
Date: Wed, 6 Jul 2016 21:56:07 +0200 [thread overview]
Message-ID: <20160706215607.785816dd@free-electrons.com> (raw)
In-Reply-To: <1467717365-27849-1-git-send-email-Vincent.Riera@imgtec.com>
Hello,
On Tue, 5 Jul 2016 12:16:05 +0100, Vicente Olivert Riera wrote:
> +ifeq ($(BR2_PACKAGE_OPENBLAS_INSTALL_TESTS),y)
> +define OPENBLAS_INSTALL_TESTS
> + for i in test ctest utest; do \
> + mkdir -p $(TARGET_DIR)/usr/share/openblas/$$i && \
> + cd $(@D)/$$i && \
> + find . -type f -perm -a=x -exec $(INSTALL) -m 0755 {} $(TARGET_DIR)/usr/share/openblas/$$i/{} \; && \
> + find . -type f -name "?in*" -exec $(INSTALL) -m 0644 {} $(TARGET_DIR)/usr/share/openblas/$$i/{} \; && \
> + find . -type f -name "*.dat" -exec $(INSTALL) -m 0644 {} $(TARGET_DIR)/usr/share/openblas/$$i/{} \; ; \
> + done
> +endef
> +OPENBLAS_POST_INSTALL_TARGET_HOOKS += OPENBLAS_INSTALL_TESTS
> +endif
To be honest, I really dislike such complicated install procedures.
Could you instead work with upstream to have them add an appropriate
target that allows to install the test programs?
Looking at the upstream Github repository, they look very active, so
getting some feedback should be possible.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-06 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:16 [Buildroot] [PATCH v2] openblas: add an option to install tests on the target Vicente Olivert Riera
2016-07-06 19:56 ` Thomas Petazzoni [this message]
2016-07-08 10:13 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706215607.785816dd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox