From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled.
Date: Fri, 8 Jul 2016 21:27:53 +0200 [thread overview]
Message-ID: <20160708212753.55d3c2ae@free-electrons.com> (raw)
In-Reply-To: <1467916777-29220-2-git-send-email-romain.naour@gmail.com>
Hello,
Adding Geoff in Cc.
On Thu, 7 Jul 2016 20:39:36 +0200, Romain Naour wrote:
> When BR2_PACKAGE_LIBSECCOMP is set, the go build system will try to
> find static library libseccomp.a since "static_build" and
> "extldflags '-static'" are used.
Indeed, in BR2_SHARED_LIBS=y builds, libseccomp.a will not be produced.
> Link runc statically only for static only build and prefer dynamic
> linking otherwise.
That's interesting, I thought Go was making static linking *mandatory*.
If that's not the case, then I would indeed prefer if we handled this
like all other packages: static linking only when BR2_STATIC_LIBS.
However, this should be done consistently for all packages: flannel and
docker-containerd also pass -extldflags '-static' unconditionally.
Geoff, Christian, do you see a problem with Romain's proposal?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-08 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 18:39 [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Romain Naour
2016-07-07 18:39 ` [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled Romain Naour
2016-07-08 19:27 ` Thomas Petazzoni [this message]
2016-07-08 19:32 ` Christian Stewart
2016-07-08 19:50 ` Thomas Petazzoni
2016-07-08 19:55 ` Christian Stewart
2016-07-11 9:47 ` Thomas Petazzoni
2016-07-13 21:18 ` Romain Naour
2016-07-24 14:45 ` Thomas Petazzoni
2016-07-07 18:39 ` [Buildroot] [PATCH 3/3] package/runc: disable for static only build Romain Naour
2016-07-08 19:47 ` Thomas Petazzoni
2016-07-24 14:49 ` Thomas Petazzoni
2016-07-08 19:22 ` [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708212753.55d3c2ae@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox