Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core: do not remove dl/ directory on distclean
Date: Mon, 11 Jul 2016 06:26:15 +0300	[thread overview]
Message-ID: <20160711032615.GJ3870@tarshish> (raw)
In-Reply-To: <1468187749-3955-1-git-send-email-yann.morin.1998@free.fr>

Hi Yann,

On Sun, Jul 10, 2016 at 11:55:49PM +0200, Yann E. MORIN wrote:
> Currently, if the dl/ directory is the default location, it is removed
> on distclean.
> 
> However, the dl/ directory is a precious location: it contains all the
> tarballs downloaded so far, and some can be relatively huge, taking some
> previous time to re-download, especially on slowish links.
> 
> Don't remove it on distclean. If the user really needs to regain some
> space, leave it to him to clean this directory up manually.

Current Makefile help text for 'distclean' says:

  delete all non-source files (including .config)

Not deleting the dl/ directory is not consistent with this description, IMO.

baruch

> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  Makefile | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 027f21c..5d840f6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -901,9 +901,6 @@ clean:
>  		$(LEGAL_INFO_DIR) $(GRAPHS_DIR)
>  
>  distclean: clean
> -ifeq ($(DL_DIR),$(TOPDIR)/dl)
> -	rm -rf $(DL_DIR)
> -endif
>  ifeq ($(O),output)
>  	rm -rf $(O)
>  endif

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2016-07-11  3:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 21:55 [Buildroot] [PATCH] core: do not remove dl/ directory on distclean Yann E. MORIN
2016-07-11  3:26 ` Baruch Siach [this message]
2016-07-11 16:34   ` Yann E. MORIN
2016-07-11 20:03     ` Peter Korsgaard
2016-07-11 20:22       ` Yann E. MORIN
2016-07-11 22:13         ` Peter Korsgaard
2016-07-12 14:28 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711032615.GJ3870@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox