From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] docs/manual: Document the variable $(PKG)_DL_REFERER
Date: Mon, 11 Jul 2016 12:11:41 +0200 [thread overview]
Message-ID: <20160711121141.23703922@free-electrons.com> (raw)
In-Reply-To: <57836D3D.5020801@free-electrons.com>
Hello,
On Mon, 11 Jul 2016 11:56:13 +0200, Romain Perier wrote:
> > This big chunk of change seems completely unrelated to your patch. Some
> > issue with your text editor?
>
> I just added this variable to the example. By doing so, it shifts the
> lines number. However, I don't think that's very useful to add this
> variable to this snippet of code, because this example seems to be
> helpful only for the most basic common cases.
Yeah, sorry, I missed the fact that you added a <pkg>_DL_REFERER
example (it was lost in the "noise" of the patch).
But indeed, I don't think adding DL_REFERER to the example is useful.
Only package needs it as of now, and I don't expect many packages to
need that in the future. So having it in the reference of available
variables is definitely necessary (we document *all* variables), but
not in the example of the tutorial.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-11 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 8:48 [Buildroot] [PATCH 0/6] Add support for AMD Catalyst graphics driver Romain Perier
2016-07-11 8:48 ` [Buildroot] [PATCH 1/6] support/download: Add support for the referer option to wget Romain Perier
2016-07-11 8:48 ` [Buildroot] [PATCH 2/6] pkg-download: Allow packages to pass an URL referer to the wget method Romain Perier
2016-07-11 9:29 ` Thomas Petazzoni
2016-07-11 16:46 ` Yann E. MORIN
2016-07-11 8:48 ` [Buildroot] [PATCH 3/6] docs/manual: Document the variable $(PKG)_DL_REFERER Romain Perier
2016-07-11 9:27 ` Thomas Petazzoni
2016-07-11 9:56 ` Romain Perier
2016-07-11 10:11 ` Thomas Petazzoni [this message]
2016-07-11 8:48 ` [Buildroot] [PATCH 4/6] package/xserver_xorg-server: add version 1.17.4 Romain Perier
2016-07-11 8:48 ` [Buildroot] [PATCH 5/6] qt: Add option for enabling the accessibility support Romain Perier
2016-07-11 8:48 ` [Buildroot] [PATCH 6/6] package/amd-catalyst-driver: Add AMD proprietary graphic stack support Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711121141.23703922@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox