From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/7] new package: ti-sgx top level package for SGX graphics accelerator
Date: Tue, 12 Jul 2016 16:57:22 +0200 [thread overview]
Message-ID: <20160712165722.6d3751fd@free-electrons.com> (raw)
In-Reply-To: <1468311988-22059-7-git-send-email-lothar.felten@gmail.com>
Hello,
On Tue, 12 Jul 2016 10:26:27 +0200, Lothar Felten wrote:
> This is a virtual package that selects the packages required for SGX support:
> ti-sgx-km, ti-sgx-um, ti-sgx-libgbm and optionally ti-sgx-demos.
This is an improper use of a virtual package. A virtual package is
*not* a meta package that is meant to depend on a bunch of other
packages to simplify their selection.
A virtual package is a package that *provides* some kind of generic
API, which is implemented by various providers. This is not the case
here: the package that actually provides the OpenGL ES and EGL APIs is
ti-sgx-um.
So I believe this whole package should be removed, and instead the four
other packages be made independent packages.
You can have a look at package/freescale-imx/Config.in for an example.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-12 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 8:26 [Buildroot] [PATCH 0/7] new package: ti-sgx - SGX graphics acceleration for TI SoCs Lothar Felten
2016-07-12 8:26 ` [Buildroot] [PATCH 1/7] ti-gfx: config help text: list supported processors Lothar Felten
2016-07-12 14:35 ` Thomas Petazzoni
2016-07-12 8:26 ` [Buildroot] [PATCH 2/7] new package: ti-sgx/ti-sgx-km kernel module SGX graphics accelerator Lothar Felten
2016-07-12 14:41 ` Thomas Petazzoni
2016-07-12 8:26 ` [Buildroot] [PATCH 3/7] new package: ti-sgx/ti-sgx-um binary libraries " Lothar Felten
2016-07-12 14:46 ` Thomas Petazzoni
2016-07-12 8:26 ` [Buildroot] [PATCH 4/7] new package: ti-sgx/ti-sgx-libgbm libgbm for " Lothar Felten
2016-07-12 14:51 ` Thomas Petazzoni
2016-07-12 8:26 ` [Buildroot] [PATCH 5/7] new package: ti-sgx/ti-sgx-demos SGX binary demos Lothar Felten
2016-07-12 14:55 ` Thomas Petazzoni
2016-07-12 8:26 ` [Buildroot] [PATCH 6/7] new package: ti-sgx top level package for SGX graphics accelerator Lothar Felten
2016-07-12 14:57 ` Thomas Petazzoni [this message]
2016-07-12 8:26 ` [Buildroot] [PATCH 7/7] add ti-sgx package to menu Lothar Felten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712165722.6d3751fd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox