From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/2] ts4800-mbrboot: new package
Date: Fri, 15 Jul 2016 18:12:17 +0200 [thread overview]
Message-ID: <20160715161217.GG3692@free.fr> (raw)
In-Reply-To: <1468594860-14932-2-git-send-email-patrick.keroulas@savoirfairelinux.com>
Patrick, All,
On 2016-07-15 11:00 -0400, Patrick Keroulas spake thusly:
> This MBR routine is based on TS' original bootloader. It is loaded by
> the bootrom stored in the companion FPGA, and chainloads an executable
> located at the beginning of the first non-fs (0xda) partition.
>
> Signed-off-by: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com>
> ---
[--SNIP--]
> diff --git a/package/ts4800-mbrboot/Config.in b/package/ts4800-mbrboot/Config.in
> new file mode 100644
> index 0000000..556b0ec
> --- /dev/null
> +++ b/package/ts4800-mbrboot/Config.in
The firmware stuff is more for firmware blobs that need to be loaded
into a device (e.g. a WiFi dongle, and ehternet card, a GPU...);
ts4800-mbrboot is really a bootloader, so it should probably go to boot/
rather than package/ and be added in the bootloader menu.
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_TS4800_MBRBOOT
> + bool "ts4800-mbrboot"
> + depends on BR2_ARM_CPU_ARMV7A
> + help
> + This package generate the ts4800 bootloader.
Please add a homepage (or if none, the github repo).
> diff --git a/package/ts4800-mbrboot/ts4800-mbrboot.mk b/package/ts4800-mbrboot/ts4800-mbrboot.mk
> new file mode 100644
> index 0000000..825a66b
> --- /dev/null
> +++ b/package/ts4800-mbrboot/ts4800-mbrboot.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# ts4800-mbrboot
> +#
> +################################################################################
> +
> +TS4800_MBRBOOT_VERSION = master
Don;t use 'master' as it is a moving target: today, it points to a
specific chageset, but tomorrow it may well point to another, thus
rendering the build non-reproducible.
Please use a tag or the sha1 of a commit, like:
TS4800_MBRBOOT_VERSION = cf8f7072ed5a4a4e48fcb9841b2e31e519ec5dca
Otherwise looks sane.
Regards,
Yann E. MORIN.
> +TS4800_MBRBOOT_SITE = $(call github,embeddedarm,ts4800-mbrboot,$(TS4800_MBRBOOT_VERSION))
> +TS4800_MBRBOOT_LICENSE = BSD-2c
> +TS4800_MBRBOOT_LICENSE_FILES = LICENSE
> +
> +define TS4800_MBRBOOT_BUILD_CMDS
> + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> +endef
> +
> +define TS4800_MBRBOOT_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0644 $(@D)/mbrboot.bin $(BINARIES_DIR)/mbrboot.bin
> +endef
> +
> +$(eval $(generic-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-07-15 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 15:00 [Buildroot] [PATCH v6 0/2] ARM: ts4800: add basic board support Patrick Keroulas
2016-07-15 15:00 ` [Buildroot] [PATCH v6 1/2] ts4800-mbrboot: new package Patrick Keroulas
2016-07-15 16:12 ` Yann E. MORIN [this message]
2016-07-15 17:24 ` Thomas Petazzoni
2016-07-15 15:01 ` [Buildroot] [PATCH v6 2/2] configs: add defconfig for TS-4800 Patrick Keroulas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715161217.GG3692@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox