Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/mesa3d: add support for Intel Vulkan driver
Date: Sat, 16 Jul 2016 14:24:02 +0200	[thread overview]
Message-ID: <20160716142402.1920be05@free-electrons.com> (raw)
In-Reply-To: <1468145355-11597-3-git-send-email-bernd.kuhls@t-online.de>

Hello,

Thanks for this patch, it looks mostly good, with one exception, see
below.

On Sun, 10 Jul 2016 12:09:15 +0200, Bernd Kuhls wrote:

> +comment "Vulkan drivers"
> +
> +config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_INTEL
> +	bool "Vulkan Intel driver"
> +	depends on BR2_i386 || BR2_x86_64
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18 # memfd.h
> +	depends on BR2_TOOLCHAIN_USES_GLIBC # ifunc, static_assert
> +	select BR2_PACKAGE_MESA3D_DRI_DRIVER_I965
> +	select BR2_PACKAGE_MESA3D_VULKAN_DRIVER
> +	select BR2_PACKAGE_XPROTO_DRI3PROTO

You are selecting BR2_PACKAGE_XPROTO_DRI3PROTO, but you have no
guarantee that BR2_PACKAGE_XORG7 is enabled. So either dri3proto is
only needed if Xorg is used and you should have a "if
BR2_PACKAGE_XORG7", or dri3proto is mandatory, and you need a "depends
on BR2_PACKAGE_XORG7" for this option.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-16 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 10:09 [Buildroot] [PATCH 1/3] package/{mesa3d, mesa3d-headers}: bump version to 12.0.1 Bernd Kuhls
2016-07-10 10:09 ` [Buildroot] [PATCH 2/3] package/mesa3d: Fix udev dependency check Bernd Kuhls
2016-07-10 13:23   ` Thomas Petazzoni
2016-07-10 10:09 ` [Buildroot] [PATCH 3/3] package/mesa3d: add support for Intel Vulkan driver Bernd Kuhls
2016-07-16 12:24   ` Thomas Petazzoni [this message]
2016-07-10 13:23 ` [Buildroot] [PATCH 1/3] package/{mesa3d, mesa3d-headers}: bump version to 12.0.1 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160716142402.1920be05@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox