Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/systemd: import daemon needs headers >= 3.11
Date: Sat, 16 Jul 2016 20:28:56 +0200	[thread overview]
Message-ID: <20160716182856.GB3882@free.fr> (raw)
In-Reply-To: <20160716142624.1e045c31@free-electrons.com>

Thomas, Peter, All,

On 2016-07-16 14:26 +0200, Thomas Petazzoni spake thusly:
> On Tue, 12 Jul 2016 10:47:31 +0200, Peter Korsgaard wrote:
> 
> > I hadn't, no. I just did a test build with 3.10 headers and glibc 2.22,
> > and it built without problems - So I've dropped this patch.

Yes, it works because glibc 2.22 (which is >= 2.19) defines it even if
not available in the kernel headers).

> So the comment from Yann in https://patchwork.ozlabs.org/patch/646796/
> that both were needed is incorrect?

So, I built a toolchain with Linux headers 3.10 and glibc 2.18. And
systemd-importd does not build:

    src/import/export-raw.c: In function 'reflink_snapshot':
    src/import/export-raw.c:271:26: error: 'O_TMPFILE' undeclared (first use in this function)
             new_fd = open(d, O_TMPFILE|O_CLOEXEC|O_NOCTTY|O_RDWR, 0600);
                              ^
    src/import/export-raw.c:271:26: note: each undeclared identifier is reported only once for each function it appears in
    Makefile:16515: recipe for target 'src/import/systemd_export-export-raw.o' failed

O_TMPFILE was added in Linux 3.11; glibc added the corresponding
definition in glib-2.19.

    glibc \ linux   | <= 3.10   | >= 3.11   |
    ----------------+-----------+-----------+
    <= 2.18         | No        | No*       |
    >= 2.19         | Yes       | Yes       |

*: headers 3.12

So, not sure where to go from there...

Note: I have not tested uClibc or musl, because,well, systemd depends on
glibc...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-07-16 18:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 20:34 [Buildroot] [PATCH] package/systemd: import daemon needs headers >= 3.11 Yann E. MORIN
2016-07-11 19:57 ` Peter Korsgaard
2016-07-11 20:23   ` Yann E. MORIN
2016-07-12  8:47     ` Peter Korsgaard
2016-07-16 12:26       ` Thomas Petazzoni
2016-07-16 18:28         ` Yann E. MORIN [this message]
2016-07-17  7:02           ` Peter Korsgaard
2016-07-17  7:18             ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160716182856.GB3882@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox