From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sun, 24 Jul 2016 16:00:48 +0200
Subject: [Buildroot] [PATCH v2 1/6] support/download: Add support to
 pass options directly to downloaders
In-Reply-To: <20160715204729.GH3692@free.fr>
References: <1468315820-9341-1-git-send-email-romain.perier@free-electrons.com>
 <1468315820-9341-2-git-send-email-romain.perier@free-electrons.com>
 <20160715204729.GH3692@free.fr>
Message-ID: <20160724160048.39770315@free-electrons.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello,

On Fri, 15 Jul 2016 22:47:29 +0200, Yann E. MORIN wrote:

> > ---  
> [--SNIP--]
> > diff --git a/support/download/bzr b/support/download/bzr
> > index e18b01f..9443e03 100755
> > --- a/support/download/bzr
> > +++ b/support/download/bzr
> > @@ -25,6 +25,7 @@ output="${1}"
> >  repo="${2}"
> >  rev="${3}"
> >  basename="${4}"
> > +dl_opts="${5}"  
> 
> So we expect the additional options to be pased as a single string?
> Why not use something like:
> 
>     shift 4 # Get rid of our options
> 
> and then:
> 
>     _bzr export ${verbose} --root="'${basename}/'" --format=tgz \
>         ${timestamp_opt} - "'${repo}'" -r "'${rev}'" \
>         ${timestamp_opt} - "${@}" "'${repo}'" -r "'${rev}'" \
> 
> Ditto for all backends, of course.
> 
> Note: I wrote the above after writing the comment below; that construct
> above would fix the concerns I expressed below.
> 
> (I'm hard to follow, am I not? My brain is really tortuous... ;-] )

Below, you're concerned that "${dl_opts}" will lead to a problem as it
will be an empty "" if no options are passed. But you suggest to use
"${@}" instead, still with "". How does that fix the particular problem
you mentioned below?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com