From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/x11r7/xserver_xorg-server: libdrm needs dri2
Date: Mon, 25 Jul 2016 22:46:19 +0200 [thread overview]
Message-ID: <20160725224619.1be7ce21@free-electrons.com> (raw)
In-Reply-To: <1469426956-23383-2-git-send-email-bernd.kuhls@t-online.de>
Hello,
On Mon, 25 Jul 2016 08:09:16 +0200, Bernd Kuhls wrote:
> While fixing
> http://autobuild.buildroot.net/results/3b2/3b2b10314cde2ecacb7fd3949990a4cac2117f4c/
> the build throws an error in the modesettings driver after libdrm CFLAGS
> were fixed by the previous patch:
>
> In file included from dri2.c:43:0:
> ./../../dri2/dri2.h:36:39: fatal error: X11/extensions/dri2tokens.h: No such file or directory
> #include <X11/extensions/dri2tokens.h>
>
> According to configure.ac the modesettings driver is enabled if libdrm was
> found:
> https://cgit.freedesktop.org/xorg/xserver/commit/configure.ac?id=bc4b234d6f4b7b211f7a9750a97524e9652d0e6e
>
> This patch adds the necessary dri2 dependency.
>
> Fixes additional build error in
> http://autobuild.buildroot.net/results/3b2/3b2b10314cde2ecacb7fd3949990a4cac2117f4c/
Could you revisit this in the light of my comments on PATCH 1/2 ?
> +ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_XPROTO_DRI2PROTO),yy)
libdrm can be used with DRI or DRI3 as well, according to the
configure.ac script.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-25 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 6:09 [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: add libdrm-specific cflags Bernd Kuhls
2016-07-25 6:09 ` [Buildroot] [PATCH 2/2] package/x11r7/xserver_xorg-server: libdrm needs dri2 Bernd Kuhls
2016-07-25 20:46 ` Thomas Petazzoni [this message]
2016-07-25 20:45 ` [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: add libdrm-specific cflags Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725224619.1be7ce21@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox