From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nettle: disable assembly optimizations for ARMv7M
Date: Mon, 25 Jul 2016 22:48:44 +0200 [thread overview]
Message-ID: <20160725224844.2ea67984@free-electrons.com> (raw)
In-Reply-To: <1469405759-3224-1-git-send-email-gustavo@zacarias.com.ar>
Hello,
On Sun, 24 Jul 2016 21:15:59 -0300, Gustavo Zacarias wrote:
> It's thumb2-only and it requires ARM instructions.
> Since V4 and V5 aren't enough either use the V7M knob to avoid
> over-complicating the conditional. Fixes:
> http://autobuild.buildroot.net/results/354/35418d33efa902d3a1a82b2cd58d8db1b1172e49/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/nettle/nettle.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nettle/nettle.mk b/package/nettle/nettle.mk
> index c133839..a94a7fc 100644
> --- a/package/nettle/nettle.mk
> +++ b/package/nettle/nettle.mk
> @@ -15,7 +15,7 @@ NETTLE_LICENSE_FILES = COPYING.LESSERv3 COPYINGv2
> NETTLE_CONF_OPTS = --disable-openssl
>
> # ARM assembly requires v6+ ISA
> -ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5),y)
> +ifeq ($(BR2_ARM_CPU_ARMV4)$(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV7M),y)
I've applied, but in the end, I'm wondering if the condition wouldn't
be simpler as:
ifeq ($(BR2_ARM_CPU_ARMV6)$(BR2_ARM_CPU_ARMV6),)
NETTLE_CONF_OPTS += --disable-assembler
endif
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-25 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 0:15 [Buildroot] [PATCH] nettle: disable assembly optimizations for ARMv7M Gustavo Zacarias
2016-07-25 20:48 ` Thomas Petazzoni [this message]
2016-07-26 21:18 ` Peter Korsgaard
2016-07-27 7:15 ` Thomas Petazzoni
2016-07-27 8:03 ` Peter Korsgaard
2016-07-27 8:13 ` Thomas Petazzoni
2016-07-27 9:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725224844.2ea67984@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox