Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5webkit: needs host-python
Date: Tue, 26 Jul 2016 09:58:09 +0200	[thread overview]
Message-ID: <20160726095809.21008ed0@free-electrons.com> (raw)
In-Reply-To: <1469486011-29173-1-git-send-email-yann.morin.1998@free.fr>

Hello,

Cc'ing Qt5 folks: Peter Seiderer and Julien Corjon.

On Tue, 26 Jul 2016 00:33:31 +0200, Yann E. MORIN wrote:
> The Qt5Webkit build system hard-codes calls to 'python', but only really
> supports python2.
> 
> We fix that similarly as we did in nodejs, by adding a python->python2
> symlink early in the PATH when configuring/building Qt5Webkit, and
> adding host-python in the dependency list.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/ea4/ea4dd00ee585f9f9ea1927b8b5fd9035e6733420/
>     http://autobuild.buildroot.org/results/323/323ba220fae70d94c81bab9a348be844e90ace91/
>     http://autobuild.buildroot.org/results/6c2/6c20c9e222f94e6b70b97b87e1393dd16da2718c/
> 
> Also slightly reorganise the dependency list, now that it no longer fits
> on a single line.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

I know the hack of creating a dummy "bin" directory, with a
python->python2 symlink is a trick already used by nodejs, but I don't
like it very much.

Is "python" hardcoded is so many places in Qt5Webkit ? If not, what
about patching it instead, and submitting the patch upstream (though
I'm not sure qtwebkit is still maintained, since they moved to
qtwebengine I believe).

Peter, Julien?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-26  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 22:33 [Buildroot] [PATCH] package/qt5webkit: needs host-python Yann E. MORIN
2016-07-26  7:58 ` Thomas Petazzoni [this message]
2016-07-26 16:11   ` Yann E. MORIN
2016-07-26 19:20     ` Thomas Petazzoni
2016-07-27 19:41 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726095809.21008ed0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox