From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ipkg: needs MMU
Date: Tue, 26 Jul 2016 14:52:48 +0200 [thread overview]
Message-ID: <20160726145248.5dc5a39a@free-electrons.com> (raw)
In-Reply-To: <20160726121429.GA3588@tarshish>
Hello,
On Tue, 26 Jul 2016 15:14:29 +0300, Baruch Siach wrote:
> You are right of course, forgive my sloppiness. To be correct for uClibc the
> code should test for __ARCH_USE_MMU__ instead of __ARCH_HAS_MMU__. But testing
> HAVE_FORK is better, I thing, since it also covers other hypothetical MMU-less
> C libraries.
Using HAVE_FORK indeed seems better. However, can you verify that it
actually works for MMU-capable platforms?
What worries me is that the code in libbb/ originally comes from
Busybox, which doesn't use autoconf. HAVE_FORK is a #define value
defined by ipkg's autoconf configure script, in config.h, and I'm not
sure if the libbb/ code includes config.h.
So, please make sure that HAVE_FORK is really taken into account when
building on MMU-capable platforms by adding some #error in the #if
defined(HAVE_FORK) test in the libbb code that you're changing.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-26 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 4:00 [Buildroot] [PATCH] ipkg: needs MMU Baruch Siach
2016-07-26 7:59 ` Thomas Petazzoni
2016-07-26 8:01 ` Thomas Petazzoni
2016-07-26 11:15 ` Baruch Siach
2016-07-26 11:48 ` Thomas Petazzoni
2016-07-26 12:14 ` Baruch Siach
2016-07-26 12:52 ` Thomas Petazzoni [this message]
2016-07-26 15:08 ` Baruch Siach
2016-07-26 15:19 ` Thomas Petazzoni
2016-07-26 18:10 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726145248.5dc5a39a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox