From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/download: support git older then 1.8.x
Date: Wed, 27 Jul 2016 23:47:55 +0200 [thread overview]
Message-ID: <20160727214755.GB5657@free.fr> (raw)
In-Reply-To: <1469653038-64643-1-git-send-email-matthew.weber@rockwellcollins.com>
Matt, All,
Nit-pick: since you applied Enrique's patch, you should probably have
used him as author.
On 2016-07-27 15:57 -0500, Matt Weber spake thusly:
> A recent commit[1] in the git downloader uses the "--no-patch" option,
> which appeared on git 1.8.4. Systems with older git versions show an
> error and fall back to the wget downloader, which isn't suitable for
> all the cases.
>
> This commit uses a "git log" variant and works on older systems.
>
> [1]
> https://github.com/buildroot/buildroot/commit/3abd5ba4243489b821d44e407528020cd8a138f8#diff-75410bcfefacf16bcd60a2a6ac77c433R73
>
> Signed-off-by: Enrique Ocana Gonzalez <eocanha@igalia.com>
Beside, you can't go adding a SoB-line for someone else. A SoB-line is
kinda legaly-binding:
http://developercertificate.org/
Enrique, if you agree that your SoB-line is warranted, we can go the
fast route: just reply to the original mail with your own SoB-line, and
all will be good in the best of the worlds! ;-)
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> support/download/git | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/git b/support/download/git
> index 663006b..416cd1b 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -76,7 +76,7 @@ _git checkout -q "'${cset}'"
>
> # Get date of commit to generate a reproducible archive.
> # %cD is RFC2822, so it's fully qualified, with TZ and all.
> -date="$( _git show --no-patch --pretty=format:%cD )"
> +date="$( _git log -1 --pretty=format:%cD )"
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> # There might be submodules, so fetch them.
> if [ ${recurse} -eq 1 ]; then
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-07-27 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 20:57 [Buildroot] [PATCH] support/download: support git older then 1.8.x Matt Weber
2016-07-27 21:47 ` Yann E. MORIN [this message]
2016-07-28 8:48 ` Enrique Ocaña González
[not found] ` <CANQCQpbXyAYztS5MkDU_nYdC6Tta9MYVLijqGuB2k_B3YpBp8Q@mail.gmail.com>
2016-07-28 11:47 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727214755.GB5657@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox