Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v11 2/2] docker-engine: new package
Date: Wed, 27 Jul 2016 23:40:55 +0200	[thread overview]
Message-ID: <20160727234055.2dad417f@free-electrons.com> (raw)
In-Reply-To: <1469394628-19412-2-git-send-email-christian@paral.in>

Hello,

On Sun, 24 Jul 2016 14:10:28 -0700, Christian Stewart wrote:
> Docker is a platform to build, ship, and run applications in portable
> containers.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>

I've applied after removing the LIBRARY_PATH variable, as you suggested.

However, there is still one thing I'm not happy with: dockerd is linked
statically against libbtrfs. It links dynamically against
libdevmapper.so, because there is no libdevmapper.a installed. However,
since libbtrfs is available in STAGING_DIR as both a shared library
*and* a static library, the Go build logic seems to prefer the static
library. This is definitely *not* what we want in the context of
Buildroot.

See:

$ arm-linux-gnueabihf-readelf -d output/target/usr/bin/dockerd | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libpthread.so.0]
 0x00000001 (NEEDED)                     Shared library: [libdl.so.0]
 0x00000001 (NEEDED)                     Shared library: [libdevmapper.so.1.02]
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]
$ grep DOCKER_ENGINE .config
BR2_PACKAGE_DOCKER_ENGINE=y
BR2_PACKAGE_DOCKER_ENGINE_DAEMON=y
# BR2_PACKAGE_DOCKER_ENGINE_EXPERIMENTAL is not set
BR2_PACKAGE_DOCKER_ENGINE_DRIVER_BTRFS=y
BR2_PACKAGE_DOCKER_ENGINE_DRIVER_DEVICEMAPPER=y
BR2_PACKAGE_DOCKER_ENGINE_DRIVER_VFS=y
$ ls -l output/staging/usr/lib/libbtrfs.*
-rwxr-xr-x 1 thomas thomas 49938 juil. 27 23:26 output/staging/usr/lib/libbtrfs.a
lrwxrwxrwx 1 thomas thomas    15 juil. 27 23:26 output/staging/usr/lib/libbtrfs.so -> libbtrfs.so.0.1
lrwxrwxrwx 1 thomas thomas    15 juil. 27 23:26 output/staging/usr/lib/libbtrfs.so.0 -> libbtrfs.so.0.1
-rwxr-xr-x 1 thomas thomas 44012 juil. 27 23:26 output/staging/usr/lib/libbtrfs.so.0.1
$ ls -l output/staging/usr/lib/libdevmapper.*
lrwxrwxrwx 1 thomas thomas     20 juil. 27 23:32 output/staging/usr/lib/libdevmapper.so -> libdevmapper.so.1.02
-rwxr-xr-x 1 thomas thomas 454192 juil. 27 23:32 output/staging/usr/lib/libdevmapper.so.1.02

Could you investigate this?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-07-27 21:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24 21:10 [Buildroot] [PATCH v11 1/2] package/btrfs-progs: install to staging directory Christian Stewart
2016-07-24 21:10 ` [Buildroot] [PATCH v11 2/2] docker-engine: new package Christian Stewart
2016-07-24 21:25   ` Christian Stewart
2016-07-27 21:40   ` Thomas Petazzoni [this message]
2016-07-27 22:12     ` Christian Stewart
2016-07-28  1:57     ` Khem Raj
2016-07-28  6:29       ` Thomas Petazzoni
2016-07-24 21:48 ` [Buildroot] [PATCH v11 1/2] package/btrfs-progs: install to staging directory Thomas Petazzoni
2016-07-24 23:35   ` Christian Stewart
2016-07-25  7:47     ` Thomas Petazzoni
2016-07-27 21:38 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160727234055.2dad417f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox