From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] kmsxx: new package
Date: Thu, 28 Jul 2016 23:34:06 +0200 [thread overview]
Message-ID: <20160728233406.30c9f31d@free-electrons.com> (raw)
In-Reply-To: <20160728193825.9199-1-maxime.ripard@free-electrons.com>
Hello,
On Thu, 28 Jul 2016 21:38:25 +0200, Maxime Ripard wrote:
> KMS++ is a suite of library and test tools to interact with KMS drivers in
> the linux kernel.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
I've applied, after doing numerous updates:
[Thomas:
- rename prompt to kms++, suggested by Yann E. Morin
- fixup the thread dependency comment
- remove the mention of the python wrapper in the Config.in help
text, since they are not installed
- fix the Config.in comment to mention the C++ and gcc >= 4.8
dependencies
- use = instead of += when appropriate
- use a loop to install the test programs
- use a loop to install the libraries
- add installation to staging as well, both the libraries and header
files
- add missing dependency on host-pkgconf
- add hash file.]
Also, it would be nice to tell upstream that CMake can not only build
stuff, but also install stuff. It is a bit silly to be using a
well-known build system, but not use it to provide proper install
targets.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-07-28 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 19:38 [Buildroot] [PATCH v3] kmsxx: new package Maxime Ripard
2016-07-28 19:49 ` Yann E. MORIN
2016-07-28 20:17 ` Thomas Petazzoni
2016-07-28 20:22 ` Yann E. MORIN
2016-07-28 20:05 ` Yann E. MORIN
2016-07-28 21:34 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728233406.30c9f31d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox