Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/Makefile.in should grab HOST_DIR headers using -isystem instead of -I.
Date: Fri, 29 Jul 2016 09:32:18 +0200	[thread overview]
Message-ID: <20160729093218.36d66c86@free-electrons.com> (raw)
In-Reply-To: <48B4EC85-773A-4F99-96D4-59577018BAB3@gmail.com>

Hello,

On Thu, 28 Jul 2016 15:04:18 -0700, Khem Raj wrote:

> >> -HOST_CPPFLAGS  = -I$(HOST_DIR)/usr/include
> >> +HOST_CPPFLAGS  = -isystem $(HOST_DIR)/usr/include  
> 
> This is quite intrusive change. avoid -isystems since it interferes with the
> default include ordering of gcc and will cause compile failure since it wont
> be able to find headers in some cases. So many packages will fail to build.
> especially gcc-6.x will hit hard

Can you give some more details? Did you look at the original commit log
for this change? It pointed out some real problems when using -I, which
in theory should be resolved by using -isystem.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-29  7:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 19:52 [Buildroot] [PATCH 1/2] package/Makefile.in should grab HOST_DIR headers using -isystem instead of -I David Raeman
2016-07-25 19:52 ` [Buildroot] [PATCH 2/2] host-dtc: Install libftd and associated header files David Raeman
2016-07-25 20:01   ` Thomas Petazzoni
2016-07-25 20:26     ` David Raeman
2016-07-25 21:39       ` Yann E. MORIN
2016-07-25 21:52 ` [Buildroot] [PATCH 1/2] package/Makefile.in should grab HOST_DIR headers using -isystem instead of -I Yann E. MORIN
2016-07-25 21:57 ` Thomas Petazzoni
2016-07-28 22:00 ` Yann E. MORIN
2016-07-28 22:04   ` Khem Raj
2016-07-29  7:32     ` Thomas Petazzoni [this message]
2016-07-29  8:16       ` Khem Raj
2016-07-29  9:23         ` Thomas Petazzoni
2016-07-29 15:08           ` Khem Raj
2016-07-29 19:35             ` David Raeman
2016-07-29 21:15               ` Yann E. MORIN
2016-07-30 14:57                 ` David Raeman
2016-08-05  4:32                   ` Khem Raj
2016-08-05  4:30               ` Khem Raj
2016-08-02 21:39     ` Thomas Petazzoni
2016-07-29  0:09   ` David Raeman
2016-07-29  4:18   ` [Buildroot] [PATCH 1/1] host-python: Find headers provided by -isystem flag in CPPFLAGS David Raeman
2016-08-01 21:59 ` [Buildroot] [PATCH 1/2] package/Makefile.in should grab HOST_DIR headers using -isystem instead of -I Yann E. MORIN
2016-08-01 22:19   ` Yann E. MORIN
2016-08-02 12:21   ` David Raeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160729093218.36d66c86@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox