From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] iperf: bump to version 2.0.9
Date: Sun, 31 Jul 2016 10:09:08 +0200 [thread overview]
Message-ID: <20160731100908.1fdf64d6@free-electrons.com> (raw)
In-Reply-To: <20160731043853.GA3620@tarshish>
Hello,
On Sun, 31 Jul 2016 07:38:53 +0300, Baruch Siach wrote:
> > [Thomas:
> > - change the download location to use downloads.sourceforge.net
>
> What is the advantage of downloads.sourceforge.net? Many packages still use
> just sourceforge.net:
Consistency amongst all packages? There are 181 packages that use
downloads.sourceforge.net...
>
> $ git grep _SITE[^\.]*sourceforge -- package/ |wc -l
> 20
... which is a lot more than 20 packages.
> > - turn the patch into a Git-formatted one, since upstream uses Git as
> > its version control system
>
> Where have you found a link to that repo? Only after googling for "iperf2 git"
> I found an indication to its existence in https://github.com/daynix/iperf2.
From https://sourceforge.net/projects/iperf2/, click on "Code".
(Yes the SourceForge UI is terrible).
> > - as noticed by Khem Raj, a C99 compiler is needed for the bool type,
> > so added AC_PROG_CC_C99 to configure.ac, and consequently added
> > IPERF_AUTORECONF = YES.
> > - removed two <pkg>_CONF_ENV variables related to the bool type, they
> > were added by an older commit
> > e13ac0ec8788092c6508636da94fe0198c18dffd back when we had a
> > config.cache shared between packages (which is no longer the case
> > today)]
> >
> > If you could submit the updated patch upstream, it would be good.
Well, I was hoping you would do it :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-31 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 9:26 [Buildroot] [PATCH] iperf: bump to version 2.0.9 Baruch Siach
2016-07-29 18:55 ` Khem Raj
2016-07-30 12:31 ` Thomas Petazzoni
2016-07-31 4:38 ` Baruch Siach
2016-07-31 8:09 ` Thomas Petazzoni [this message]
2016-07-31 8:25 ` Baruch Siach
2016-08-05 10:21 ` Thomas Petazzoni
2016-08-05 11:24 ` Baruch Siach
2016-08-05 12:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731100908.1fdf64d6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox