From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] initscripts: add newline to network stop message
Date: Tue, 2 Aug 2016 22:12:01 +0200 [thread overview]
Message-ID: <20160802221201.3d07282f@free-electrons.com> (raw)
In-Reply-To: <20160802195040.7210-1-vivien.didelot@savoirfairelinux.com>
Hello,
On Tue, 2 Aug 2016 15:50:40 -0400, Vivien Didelot wrote:
> The output of "/etc/init.d/S40network stop" was lacking a newline due to
> the usage of printf. Fix it by using echo instead.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> package/initscripts/init.d/S40network | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/initscripts/init.d/S40network b/package/initscripts/init.d/S40network
> index 7b11d8b..213f5b5 100755
> --- a/package/initscripts/init.d/S40network
> +++ b/package/initscripts/init.d/S40network
> @@ -12,7 +12,7 @@ case "$1" in
> /sbin/ifup -a
> ;;
> stop)
> - printf "Stopping network..."
> + echo "Stopping network..."
> /sbin/ifdown -a
> ;;
> restart|reload)
No, using printf is the right thing to do. However, there should
instead be:
printf "Stopping network: "
...
[ $? -eq 0 ] && echo "OK" || echo "FAIL"
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-08-02 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 19:50 [Buildroot] [PATCH] initscripts: add newline to network stop message Vivien Didelot
2016-08-02 20:12 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802221201.3d07282f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox