Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/oprofile: disable for m68k
Date: Fri, 5 Aug 2016 00:10:46 +0200	[thread overview]
Message-ID: <20160805001046.3b89b0f8@free-electrons.com> (raw)
In-Reply-To: <1470347885-13186-1-git-send-email-romain.naour@gmail.com>

Hello,

On Thu,  4 Aug 2016 23:58:05 +0200, Romain Naour wrote:

>  	# no memory barrier functions
> -	depends on !BR2_xtensa && !BR2_microblaze
> +	depends on !BR2_xtensa && !BR2_microblaze && !BR2_m68k

I was also looking at this, and I think we need to invert the logic.
There's a file in oprofile sources that defines rmb() for a number of
architectures. We should have a BR2_PACKAGE_OPROFILE_ARCH_SUPPORTS that
is set to 'y' only for the architectures that are explicitly supported
by oprofile.

Could you look into this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-08-04 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 21:58 [Buildroot] [PATCH v2] package/oprofile: disable for m68k Romain Naour
2016-08-04 22:10 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805001046.3b89b0f8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox