From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openblas: fix build issues on ARM
Date: Sun, 7 Aug 2016 11:29:35 +0200 [thread overview]
Message-ID: <20160807112935.3a9ca090@free-electrons.com> (raw)
In-Reply-To: <9111A0DF-B21B-4A2E-9CA7-FEAE55D1E91A@gmail.com>
Hello,
On Sun, 7 Aug 2016 01:13:40 -0700, Khem Raj wrote:
> > + - Assuming that one uses -mfloat-abi=hard on ARMv7 is completely
> > + wrong. -mfloat-abi=softfp is a perfectly valid choice on ARMv7, and
> > + OpenBLAS should not make such assumptions.
>
> perhaps they do not support softfp, this should be confirmed.
Hum, right, they might have some assembly code that assumes floating
point arguments are passed in FP registers.
> > +-ifeq ($(CORE), ARMV5)
> > +-CCOMMON_OPT += -marm -march=armv5
> > +-FCOMMON_OPT += -marm -march=armv5
>
> -marm option is also removed. I wonder if this code will now build when we have thumb/thumb2 ISA
> selected as default for an arm machine.
So maybe I should keep the -marm flag here, and in fact just remove
-march=armv5. Also, for the ARMv7-A, I could keep the flag, and make
the ARMV7 OpenBLAS platform only selectable when ARMv7 + EABIhf +
VFPv3/v4 is available.
Thanks for the feedback!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-08-07 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 21:53 [Buildroot] [PATCH] openblas: fix build issues on ARM Thomas Petazzoni
2016-08-07 8:13 ` Khem Raj
2016-08-07 9:29 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807112935.3a9ca090@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox