Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/rt-tests: remove sched_setattr/sched_getattr API for SuperH arch
Date: Tue, 9 Aug 2016 21:30:29 +0300	[thread overview]
Message-ID: <20160809183029.GG845@tarshish> (raw)
In-Reply-To: <8216095c-f7c2-a862-c685-fe11e2bd2f32@gmail.com>

Hi Romain,

On Tue, Aug 09, 2016 at 12:34:24PM +0200, Romain Naour wrote:
> Le 08/08/2016 ? 06:42, Baruch Siach a ?crit :
> > On Mon, Aug 08, 2016 at 12:03:17AM +0200, Romain Naour wrote:
> >> This commit remove rt-sched.o from librttest and pi_stress test program
> >> only for SuperH arch which doesn't have __NR_sched_setattr and
> >> __NR_sched_getattr syscalls defined.
> >>
> >> Patch [1] adding these syscalls has not been merged in upstream kernel
> >> (4.7).
> > 
> > But these syscalls were added for 4.8-rc1 (commit 74bdaa611fa69). This 
> > solution prevents sched_{set,get}attr use even for future v4.8+ kernels.
> 
> Thanks for this info, I haven't checked the upcoming 4.8 kernel.
> 
> However, it means that pi_stress should depends on BR2_sh and
> BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8. But this symbol doesn't exist yet in Buildroot.
> 
> I think this patch can be commited as is (kernel 4.8 will be released after
> 2016.08) and the dependency on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8 can be added
> in a follow up patch.

Alternatively, you may patch src/include/rt-sched.h to add sh syscall numbers, 
in addition to the existing i386, x86_64, and ARM ones. That would fix the 
current build issue, and would also be future proof. Such a patch might even 
be acceptable upstream.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2016-08-09 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-07 22:03 [Buildroot] [PATCH 1/2] package/rt-tests: remove sched_setattr/sched_getattr API for SuperH arch Romain Naour
2016-08-07 22:03 ` [Buildroot] [PATCH 2/2] package/rt-tests: remove dependency on headers >= 3.14 Romain Naour
2016-08-08  4:42 ` [Buildroot] [PATCH 1/2] package/rt-tests: remove sched_setattr/sched_getattr API for SuperH arch Baruch Siach
2016-08-09 10:34   ` Romain Naour
2016-08-09 18:30     ` Baruch Siach [this message]
2016-08-15 15:59       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809183029.GG845@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox