From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/9] execline: new package
Date: Tue, 9 Aug 2016 22:22:51 +0200 [thread overview]
Message-ID: <20160809222251.1e58104e@itchy> (raw)
In-Reply-To: <20160809100912.0f7738b3@free-electrons.com>
Hi!
Le Tue, 9 Aug 2016 10:09:12 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
> On Mon, 8 Aug 2016 23:02:13 +0200, Eric Le Bihan wrote:
> > This package provides execline, a (non-interactive) scripting
> > language, like sh, used in the s6 supervision system.
> >
> > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> > ---
> > package/Config.in | 1 +
> > package/execline/Config.in | 15 +++++++++
> > package/execline/Config.in.host | 7 +++++
>
> Why do we need an option visible in menuconfig to enable this as a
> host package? Why do we need the host package at all?
I made the host variant of execline visible in menuconfig so the end
user knows it can be used to write post-build script (same goes for
the host variant of s6-rc). Anyway, if this is supefluous, I will remove
it.
> > +define EXECLINE_CONFIGURE_CMDS
> > + (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure
> > $(EXECLINE_CONFIGURE_OPTS)) +endef
> > +
> > +define EXECLINE_BUILD_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D)
> > +endef
> > +
> > +define EXECLINE_INSTALL_TARGET_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) DESTDIR=$(TARGET_DIR)
> > install
>
> You're using MAKE1 to build the target variant, but MAKE to build the
> host variant. Is this expected?
This looks like a copy paste/error...
Best regards,
--
ELB
next prev parent reply other threads:[~2016-08-09 20:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 21:02 [Buildroot] [PATCH 0/9] Introducing service supervision/management with s6 Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 1/9] skalibs: new package Eric Le Bihan
2016-08-09 8:06 ` Thomas Petazzoni
2016-08-09 20:16 ` Eric Le Bihan
2016-08-09 20:35 ` Thomas Petazzoni
[not found] ` <20160809221532.3f36d369@itchy>
2016-12-04 18:08 ` Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 2/9] execline: " Eric Le Bihan
2016-08-09 8:09 ` Thomas Petazzoni
2016-08-09 20:22 ` Eric Le Bihan [this message]
2016-08-09 20:36 ` Thomas Petazzoni
2016-08-08 21:02 ` [Buildroot] [PATCH 3/9] s6: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 4/9] s6-dns: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 5/9] s6-networking: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 6/9] s6-rc: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 7/9] s6-portable-utils: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 8/9] s6-linux-utils: " Eric Le Bihan
2016-08-08 21:02 ` [Buildroot] [PATCH 9/9] s6-linux-init: " Eric Le Bihan
2016-08-09 4:14 ` [Buildroot] [PATCH 0/9] Introducing service supervision/management with s6 Waldemar Brodkorb
2016-08-09 19:54 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809222251.1e58104e@itchy \
--to=eric.le.bihan.dev@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox