From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ncurses: fix wide-char enabled compilation for noMMU targets
Date: Tue, 9 Aug 2016 23:56:38 +0200 [thread overview]
Message-ID: <20160809235638.29981f7d@free-electrons.com> (raw)
In-Reply-To: <7227BE30-A6E5-4184-ABFC-E15915CFEB07@gmail.com>
Hello,
On Wed, 3 Aug 2016 23:47:51 -0700, Khem Raj wrote:
> > ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
> > NCURSES_CONF_OPTS += --enable-widec
> > +# for noMMU we need to set it explicitely, fixes cchar_t problem
> > +NCURSES_CPPFLAGS += -D_XOPEN_SOURCE_EXTENDED
>
> May be you need to define NCURSES_WIDECHAR=1 instead
Cannot work (at least without patching) : it gets undef'ed by ncurses:
#undef NCURSES_WIDECHAR
#if defined(_XOPEN_SOURCE_EXTENDED) || defined(_XPG5)
#define NCURSES_WIDECHAR
#endif
But this test from ncurses is weird. My understanding of the feature
macros like _XOPEN_SOURCE_EXTENDED is that they should be *defined* by
the program/library that wants to use the specific features hidden
behind this macro. This is what
https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html
explains.
So why is ncurses *testing* this?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-08-09 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 8:28 [Buildroot] [PATCH] ncurses: fix wide-char enabled compilation for noMMU targets Waldemar Brodkorb
2016-08-04 6:47 ` Khem Raj
2016-08-09 21:56 ` Thomas Petazzoni [this message]
2016-08-21 13:20 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809235638.29981f7d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox