Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] package/android-tools: drop musl-compatibility cdefs patching out
Date: Sun, 14 Aug 2016 23:57:19 +0200	[thread overview]
Message-ID: <20160814215719.GH30771@free.fr> (raw)
In-Reply-To: <0cc766e7-d59b-3e2c-bf9e-abba7f6cb94b@mind.be>

Arnout, All,

On 2016-08-14 23:34 +0200, Arnout Vandecappelle spake thusly:
> On 12-08-16 22:49, Yann E. MORIN wrote:
> > We now always have a sys/cdefs.h, so we no longer need to patch it out.
> > 
> > Simplify the patch by removing any hunk removing cdefs.h or the use of
> > __BEGIN_DECLS/__END_DECLS. However, it must be included when macros it
> > defines are being used.
> > 
> > Also, renumber patches to guarantee ordering.
> 
>  You actually changed the ordering...
> 
> 0005-fix-big-endian-build.patch
> 0005-fix-static-link-zlib.patch
> 
> ->
> 
> 0005-fix-static-link-zlib.patch
> 0006-fix-big-endian-build.patch
> 
> so I guess the order doesn't matter.

No it does not. But if you git-log the package, you'll see that the
static fix was introduced before the big-endian one.

>  But anyway, after careful review of the patch-in-patch changes:
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-08-14 21:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12 20:49 [Buildroot] [PATCH 0/8] musl: add compatibility cdefs.h header (branch yem/cdefs) Yann E. MORIN
2016-08-12 20:49 ` [Buildroot] [PATCH 1/8] package/netbsd-compat-headers: provide compatibility headers not in musl Yann E. MORIN
2016-08-12 21:30   ` Khem Raj
2016-08-12 21:39     ` Yann E. MORIN
2016-08-13  2:35       ` Khem Raj
2016-08-14 10:41   ` Baruch Siach
2016-08-14 21:20   ` Arnout Vandecappelle
2016-08-14 21:56     ` Yann E. MORIN
2016-08-12 20:49 ` [Buildroot] [PATCH 2/8] package/rpcbind: include cdefs.h where needed Yann E. MORIN
2016-08-14 21:21   ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 3/8] package/aircrack-ng: drop a musl-compatibility patch Yann E. MORIN
2016-08-14 21:22   ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 4/8] package/android-tools: drop musl-compatibility cdefs patching out Yann E. MORIN
2016-08-14 21:34   ` Arnout Vandecappelle
2016-08-14 21:57     ` Yann E. MORIN [this message]
2016-08-12 20:49 ` [Buildroot] [PATCH 5/8] package/bcusdk: drop a musl-compatibility patch Yann E. MORIN
2016-08-14 21:41   ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 6/8] package/libsepol: " Yann E. MORIN
2016-08-14 21:48   ` Arnout Vandecappelle
2016-08-12 20:50 ` [Buildroot] [PATCH 7/8] package/linknx: " Yann E. MORIN
2016-08-14 21:49   ` Arnout Vandecappelle
2016-08-12 20:50 ` [Buildroot] [PATCH 8/8] package/qlibc: " Yann E. MORIN
2016-08-14 21:50   ` Arnout Vandecappelle
2016-08-14 21:59 ` [Buildroot] [PATCH 0/8] musl: add compatibility cdefs.h header (branch yem/cdefs) Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160814215719.GH30771@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox