From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/simh: new package
Date: Wed, 17 Aug 2016 22:21:07 +0200 [thread overview]
Message-ID: <20160817222107.5e27e95e@free-electrons.com> (raw)
In-Reply-To: <1471437282-14799-1-git-send-email-lothar.felten@gmail.com>
Hello,
On Wed, 17 Aug 2016 14:34:42 +0200, Lothar Felten wrote:
> This package provides the simh multi-system emulator.
> The simh makefile is replaced by a cmake project to handle cross compilation
> correctly. Only a subset of the available simulators is built.
I am a bit concerned by the fact that you are entirely replacing the
upstream build system by a CMake based one. Your patch adding CMake
based build is already 394 lines long, and doesn't support all the
simulators.
Indeed the upstream makefile seems a bit crazy. Have you talked with
upstream to see how those issues can be fixed?
I'm not sure we want to carry in Buildroot a completely new build
system for this package.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-08-17 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 12:34 [Buildroot] [PATCH v3 1/1] package/simh: new package Lothar Felten
2016-08-17 20:07 ` Samuel Martin
2016-08-18 21:45 ` Lothar Felten
2016-08-19 7:15 ` Samuel Martin
2016-08-17 20:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817222107.5e27e95e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox