From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] logrotate: fix up build error with gcc 6
Date: Thu, 18 Aug 2016 21:21:25 +0200 [thread overview]
Message-ID: <20160818212125.1cb8e7ae@free-electrons.com> (raw)
In-Reply-To: <1471539849-3766-2-git-send-email-rahul.bedarkar@imgtec.com>
Hello,
On Thu, 18 Aug 2016 22:34:09 +0530, Rahul Bedarkar wrote:
> With gcc version 6, we see following warning.
>
> config.c: In function 'strndup':
> config.c:87:10: error: nonnull argument 's' compared to NULL [-Werror=nonnull-compare]
> if(!s)
> ^
> cc1: all warnings being treated as errors
>
> strndup is declared with nonnull attribute for first parameter. In such
> cases, gcc 6 warns when we check for nonnull explicitly. So drop the
> check for nonnull.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/6dc/6dc2eb22104076920d77425b1e608ef9b9e01c94/
>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Can this apply without the 3.10.0 bump?
Indeed PATCH 2/2 being a bug fix, it would be a candidate for the
"master" branch, while PATCH 1/2 being a version bump, we can only
commit it to the "next" branch.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-08-18 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 17:04 [Buildroot] [PATCH 1/2] logrotate: bump version to 3.10.0 Rahul Bedarkar
2016-08-18 17:04 ` [Buildroot] [PATCH 2/2] logrotate: fix up build error with gcc 6 Rahul Bedarkar
2016-08-18 19:21 ` Thomas Petazzoni [this message]
2016-08-19 5:44 ` Rahul Bedarkar
2016-08-19 10:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818212125.1cb8e7ae@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox