From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 20 Aug 2016 16:10:24 +0200
Subject: [Buildroot] [PATCH] pinentry: fix build issue with gcc 5.x
In-Reply-To: <1471701636-30275-1-git-send-email-thomas.petazzoni@free-electrons.com>
References: <1471701636-30275-1-git-send-email-thomas.petazzoni@free-electrons.com>
Message-ID: <20160820141024.GA5784@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On 2016-08-20 16:00 +0200, Thomas Petazzoni spake thusly:
> pinentry currently fails to build with gcc 5.x, because it uses some
> functionality from std::string that requires C++11 without passing the
> appropriate -std= value. We fix this by passing a proper -std= option
> when gcc >= 5.x. Note that this can be removed once pinentry is bumped
> to the newest version (currently 0.9.7) because they no longer use
> std::string in the Qt part.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/6ea64f692acaebc4d58f3371c632b5121500f17e/
>   (and many, many similar build failures)
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> One-beer-granted-to: Yann E. MORIN <yann.morin.1998@free.fr>

So be it, then! ;-)

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/pinentry/pinentry.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/pinentry/pinentry.mk b/package/pinentry/pinentry.mk
> index 09a7705..bcb910a 100644
> --- a/package/pinentry/pinentry.mk
> +++ b/package/pinentry/pinentry.mk
> @@ -14,6 +14,13 @@ PINENTRY_DEPENDENCIES = \
>  	host-pkgconf
>  PINENTRY_CONF_OPTS += --without-libcap       # requires PAM
>  
> +# pinentry uses some std::string functionality that needs C++11
> +# support when gcc >= 5.x. This should be removed when bumping
> +# pinentry, since newer versions no longer use std::string.
> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y)
> +PINENTRY_CONF_ENV = CXXFLAGS="$(TARGET_CXXFLAGS) -std=gnu++11"
> +endif
> +
>  # build with X if available
>  ifeq ($(BR2_PACKAGE_XORG7),y)
>  PINENTRY_CONF_OPTS += --with-x
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'