Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pinentry: fix build issue with gcc 5.x
Date: Sat, 20 Aug 2016 22:27:20 +0200	[thread overview]
Message-ID: <20160820222720.51b932bf@free-electrons.com> (raw)
In-Reply-To: <EB15F48B-6DC4-4D66-882B-C2173F06427C@gmail.com>

Hello,

On Sat, 20 Aug 2016 13:19:02 -0700, Khem Raj wrote:

> > +# pinentry uses some std::string functionality that needs C++11
> > +# support when gcc >= 5.x. This should be removed when bumping
> > +# pinentry, since newer versions no longer use std::string.
> > +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y)
> > +PINENTRY_CONF_ENV = CXXFLAGS="$(TARGET_CXXFLAGS) -std=gnu++11"
> > +endif  
> 
> Should this package be restricted to gcc5 and newer only, I assume
> it will break with gcc 4.x too and c++11 may not be there, gcc5 atleast
> has the support its just not default

We have lots of gcc 4.x toolchains, and we haven't had any build
failure. I believe it builds fine with gcc 4.x.

The code requiring C++11 that causes the build failure with gcc 5.x is
in libstdc++ itself. As I discussed with Yann on IRC, I don't really
understand why some code in libstdc++ uses C++11, without gcc 5.x
defaulting to C++11.

Maybe you have a clue?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-08-20 20:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20 14:00 [Buildroot] [PATCH] pinentry: fix build issue with gcc 5.x Thomas Petazzoni
2016-08-20 14:10 ` Yann E. MORIN
2016-08-20 20:19 ` Khem Raj
2016-08-20 20:27   ` Thomas Petazzoni [this message]
2016-08-20 20:52     ` Khem Raj
2016-08-20 20:40 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160820222720.51b932bf@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox