Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libraw: fix build with gcc 6.x
Date: Sat, 27 Aug 2016 09:25:37 +0200	[thread overview]
Message-ID: <20160827092537.10f48a8d@free-electrons.com> (raw)
In-Reply-To: <3cb051ae-2a23-7a0a-edf0-8f901157f7f0@mind.be>

Hello,

On Sat, 27 Aug 2016 00:26:31 +0200, Arnout Vandecappelle wrote:

>  Hm, turns out that what you put here indeed doesn't fix it completely:
> 
> internal/dcraw_common.cpp: In member function ?void LibRaw::kodak_radc_load_raw()?:
> internal/dcraw_common.cpp:2491:3: error: narrowing conversion of ?-2? from ?int?
> to ?char? inside { } [-Wnarrowing]

Weird, I definitely built the package with a gcc 6.x toolchain, and it
was building fine. Maybe the failure only occurred with some additional
optional dependencies enabled?

>  I was waiting for upstream to fix that one as well (Debian runs into it too, on
> the 0.17 branch, so it ought to be fixed quickly).
> 
>  And indeed, Debian has fixed it already... I'll send a patch.

Your solution is also shorter/simpler, indeed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-08-27  7:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 21:17 [Buildroot] [PATCH] libraw: fix build with gcc 6.x Thomas Petazzoni
2016-08-26 22:26 ` Arnout Vandecappelle
2016-08-27  7:25   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827092537.10f48a8d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox