Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 11/16 v3] docs/manual: document the br2-external ID
Date: Sat, 27 Aug 2016 22:13:03 +0200	[thread overview]
Message-ID: <20160827221303.23e011ec@free-electrons.com> (raw)
In-Reply-To: <1668718ade9cb831725de8eed23056eefa7879c6.1468750623.git.yann.morin.1998@free.fr>

Hello,

On Sun, 17 Jul 2016 12:34:31 +0200, Yann E. MORIN wrote:

> diff --git a/docs/manual/customize-outside-br.txt b/docs/manual/customize-outside-br.txt
> index 9ad177d..839d1b1 100644
> --- a/docs/manual/customize-outside-br.txt
> +++ b/docs/manual/customize-outside-br.txt
> @@ -57,19 +57,50 @@ Or disable the usage of external definitions:
>  buildroot/ $ make BR2_EXTERNAL= xconfig
>  -----
>  
> -+BR2_EXTERNAL+ allows three different things:
> +A +BR2_EXTERNAL+ tree must contain at least those three files:
> +
> ++external.id+::

I thought this file was optional when there was a single external tree,
but you're saying it's mandatory here. Is it because the "no
external.id file" case is only supported for backward compat, and we
expect that new users write an external.id, regardless of whether they
are using a single or multiple external trees ?

> +   That file should contain the ID for the +BR2_EXTERNAL+ tree.
> +   That ID is used to construct the +BR2_EXTERNAL_$(ID)+ variable,
> +   available in +Config.in+ and +external.mk+ (see below), so that ID
> +   must be a valid make and Kconfig variable. Buildroot sets
> +   +BR2_EXTERNAL_$(ID)+ to the path of the +BR2_EXTERNAL+ tree.
> +   The format for this file is a single line with the ID.
> ++
> +Examples of an +external.mk+ file that declares the ID +FOO+:

Huh? Is it really external.mk that contains the ID ?

> ++
> +----
> +$ cat external.mk

Ditto.

> +FOO
> +----
> ++
> +Examples of IDs and the corresponding +BR2_EXTERNAL_$(ID)+ variable:
> ++
> +  * +FOO+ -> +BR2_EXTERNAL_FOO+
> +  * +BAR_42+ -> +BR2_EXTERNAL_BAR_42+
> +  * ...

Maybe mention which characters are allowed and which ones are not
allowed?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-08-27 20:13 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-17 10:34 [Buildroot] [PATCH 00/16 v3] br2-external: support multiple trees at once (branch yem/multi-br2-external-ID-7) Yann E. MORIN
2016-07-17 10:34 ` [Buildroot] [PATCH 01/16 v3] core: move pkg-utils.mk to support/ Yann E. MORIN
2016-07-24 20:43   ` Romain Naour
2016-08-27 14:11   ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 02/16 v3] core: commonalise the bundled and br2-external %_defconfig rules Yann E. MORIN
2016-07-30 20:48   ` Romain Naour
2016-08-27 14:12   ` Thomas Petazzoni
2016-08-27 14:16     ` Yann E. MORIN
2016-08-27 17:10       ` Arnout Vandecappelle
2016-07-17 10:34 ` [Buildroot] [PATCH 03/16 v3] doc/asciidoc: add possibility to define document dependencies Yann E. MORIN
2016-08-06 15:02   ` Romain Naour
2016-08-27 14:14   ` Thomas Petazzoni
2016-08-27 14:42     ` Yann E. MORIN
2016-08-27 19:58   ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 04/16 v3] core: introduce an intermediate rule before the configurators Yann E. MORIN
2016-08-06 15:13   ` Romain Naour
2016-08-27 14:47     ` Yann E. MORIN
2016-08-27 19:39   ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 05/16 v3] core: move rule to create basic directories Yann E. MORIN
2016-08-06 15:16   ` Romain Naour
2016-08-27 14:14     ` Thomas Petazzoni
2016-08-27 14:34       ` Yann E. MORIN
2016-08-27 19:41   ` Thomas Petazzoni
2016-08-27 22:07     ` Yann E. MORIN
2016-07-17 10:34 ` [Buildroot] [PATCH 06/16 v3] core: introduce a generated kconfig snippet Yann E. MORIN
2016-08-06 15:18   ` Romain Naour
2016-08-27 14:16   ` Thomas Petazzoni
2016-08-27 15:01     ` Yann E. MORIN
2016-08-28 20:50     ` Peter Korsgaard
2016-08-29  7:19       ` Thomas Petazzoni
2016-08-29  7:50         ` Peter Korsgaard
2016-08-29 10:02           ` Thomas Petazzoni
2016-08-29 22:14             ` Arnout Vandecappelle
2016-08-29 22:25               ` Yann E. MORIN
2016-08-29 22:16       ` Yann E. MORIN
2016-08-29 22:46         ` Arnout Vandecappelle
2016-08-30  9:00           ` Yann E. MORIN
2016-08-30  9:40             ` Peter Korsgaard
2016-08-30 20:01             ` Arnout Vandecappelle
2016-09-01 17:52       ` Yann E. MORIN
2016-09-01 18:57         ` Peter Korsgaard
2016-09-01 21:30           ` Arnout Vandecappelle
2016-09-01 21:51             ` Peter Korsgaard
2016-08-27 19:46   ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 07/16 v3] docs/manual: prepare-config can be used as a dependency of documents Yann E. MORIN
2016-08-06 15:19   ` Romain Naour
2016-08-27 19:58   ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 08/16 v3] core: do not hard-code inclusion of br2-external in Kconfig Yann E. MORIN
2016-08-06 15:21   ` Romain Naour
2016-08-27 20:00   ` Thomas Petazzoni
2016-08-27 22:14     ` Yann E. MORIN
2016-07-17 10:34 ` [Buildroot] [PATCH 09/16 v3] core: get rid of our dummy br2-external tree Yann E. MORIN
2016-08-06 15:30   ` Romain Naour
2016-08-06 15:37     ` Yann E. MORIN
2016-07-17 10:34 ` [Buildroot] [PATCH 10/16 v3] core: introduce per br2-external ID Yann E. MORIN
2016-08-06 15:41   ` Romain Naour
2016-08-27 20:10   ` Thomas Petazzoni
2016-08-27 22:15     ` Yann E. MORIN
2016-08-27 21:49   ` Arnout Vandecappelle
2016-08-27 21:59     ` Yann E. MORIN
2016-08-28 10:48       ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 11/16 v3] docs/manual: document the " Yann E. MORIN
2016-08-06 15:48   ` Romain Naour
2016-08-27 15:05     ` Yann E. MORIN
2016-08-27 20:13   ` Thomas Petazzoni [this message]
2016-08-27 22:19     ` Yann E. MORIN
2016-08-30 20:36   ` Arnout Vandecappelle
2016-07-17 10:34 ` [Buildroot] [PATCH 12/16 v3] core: handle .br-external in a make rule Yann E. MORIN
2016-07-24 20:05   ` Romain Naour
2016-07-25 21:13     ` Yann E. MORIN
2016-08-27 15:51       ` Yann E. MORIN
2016-08-27 20:16   ` Thomas Petazzoni
2016-08-27 22:22     ` Yann E. MORIN
2016-08-28 10:49       ` Thomas Petazzoni
2016-07-17 10:34 ` [Buildroot] [PATCH 13/16 v3] core: add support for multiple br2-external trees Yann E. MORIN
2016-07-24 20:25   ` Romain Naour
2016-07-25 21:25     ` Yann E. MORIN
2016-08-27 20:20   ` Thomas Petazzoni
2016-08-29 22:11     ` Yann E. MORIN
2016-07-17 10:34 ` [Buildroot] [PATCH 14/16 v3] support/scripts: teach gen-manual-lists about BR2_EXTERNAL Yann E. MORIN
2016-08-06 15:59   ` Romain Naour
2016-07-17 10:34 ` [Buildroot] [PATCH 15/16 v3] docs/manual: include packages from BR2_EXTERNAL if set Yann E. MORIN
2016-08-06 16:07   ` Romain Naour
2016-07-17 10:34 ` [Buildroot] [PATCH 16/16 v3] docs/manual: document multi br2-external Yann E. MORIN
2016-08-06 16:15   ` Romain Naour
2016-08-30 21:37 ` [Buildroot] [PATCH 00/16 v3] br2-external: support multiple trees at once (branch yem/multi-br2-external-ID-7) Arnout Vandecappelle
2016-08-31  6:15   ` Peter Korsgaard
2016-08-31  7:14     ` Thomas Petazzoni
2016-08-31  9:26       ` Yann E. MORIN
2016-09-01 21:43         ` Arnout Vandecappelle
2016-09-01 21:46           ` Yann E. MORIN
2016-09-01 22:04             ` Arnout Vandecappelle
2016-09-04 18:42           ` Peter Korsgaard
2016-09-04 21:14             ` Yann E. MORIN
2016-09-05 10:31               ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827221303.23e011ec@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox