From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 27 Aug 2016 22:30:13 +0200 Subject: [Buildroot] [PATCH 4/4 v3] kodi: allow enablement of libamcodec as codec if selected In-Reply-To: References: <20160624182256.11909-1-daggs@gmx.com> <20160624182256.11909-4-daggs@gmx.com> <37g24dxqbs.ln2@ID-313208.user.individual.net> Message-ID: <20160827223013.32645edf@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 2 Jul 2016 19:58:21 +0200, daggs wrote: > as prefix is set to /usr (see output/build/kodi-16.1-Jarvis/config.log), I'm not sure fixing prefix is the answer. > in general, replacing the include lines with the follows: > INCLUDES += -I$(shell $(CC) --print-sysroot)/$(prefix)/include/amcodec > INCLUDES += -I$(shell $(CC) --print-sysroot)/$(prefix)/include/amplayer You can also do: -I=$(prefix)/include/amcodec '=' is automatically replaced by gcc by the sysroot path. However, as it was discussed, there should be a choice between: - amcodec headers are meant to be installed in /usr/include/amcodec, in which case Kodi should #include , and then the amcodec headers also use #include internally. - amcodec headers are meant to be installed in /usr/include/ directory, in which case Kodi should #include , and then the amcodec headers can do #include The drawback with the second option is obviously the potential for conflicting file names in /usr/include. Since the patch doesn't work as-is, I've marked it as "Changes Requested" in patchwork. Please come up with a better solution, possibly by talking with the libamcodec maintainer. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com