From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Tue, 30 Aug 2016 11:00:18 +0200 Subject: [Buildroot] [PATCH 06/16 v3] core: introduce a generated kconfig snippet In-Reply-To: References: <20160827161601.2fd0e8f5@free-electrons.com> <87poosaa9d.fsf@dell.be.48ers.dk> <20160829221610.GC5829@free.fr> Message-ID: <20160830090018.GA5815@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2016-08-30 00:46 +0200, Arnout Vandecappelle spake thusly: > On 30-08-16 00:16, Yann E. MORIN wrote: > > Peter, Thomas, All, > > > > On 2016-08-28 22:50 +0200, Peter Korsgaard spake thusly: > >>>>>>> "Thomas" == Thomas Petazzoni writes: > >> > On Sun, 17 Jul 2016 12:34:26 +0200, Yann E. MORIN wrote: > >> >> +# Ensure the kconfig snippet is generated (for MANUAL_GEN_LISTS, below): > >> >> +MANUAL_DEPENDENCIES += prepare-kconfig > >> > >> > It's a bit crazy the complexity that we have just to allow our manual > >> > to have the list of all packages in Buildroot. I'm not even sure this > >> > section of the manual is that useful, to be honest. But oh well, that's > >> > supported today, so we have to continue support it. > >> > >> Why do we _HAVE_ to continue to support it? > >> > >> If we don't find the complexity worth the added value (I personally > >> don't, I think we could just ask people to look under package/ for the > >> list of packages), then we should just remove it. > > > > I'm not entirely against removing the list of out packages from our > > manual. > > > > Yet, for some users of br2-external trees, they may still want to have > > the list of their packages in their manuals, build with the asciidoc > > infrastructure. > > > > It is entirely imaginable that such users of br2-external have packages > > annotated with some documentation for those packages, and want to > > include that doc in their manual, so need to generate that list from > > Kconfig. > > I'm not really enthousiastic about keeping complexity in our Makefiles for > imaginary users that may want to have such and such feature :-P > > I'm very enthousiastic when people contribute some feature that I'm never going > to use myself - but in that case, we know that there is at least one user (the > contributor). But here, we really have added a feature with no known users. Have you read what I wrote: I *am* using it. http://lists.busybox.net/pipermail/buildroot/2016-August/171055.html > At > the time, it didn't add (much) complexity, but more and more it's starting to > weigh down I think. > > For sure, the asciidoc support is even more difficult to understand and > maintain than the normal package infras. And I seem to have a good track-record at looking at it: $ git log --follow --pretty=%an package/doc-asciidoc.mk |sort |uniq -c |sort -k1nr,2 22 Yann E. MORIN 8 Samuel Martin 7 Thomas De Schampheleire 2 Thomas Petazzoni 1 Atul Singh 1 J?r?me Pouiller So, please, please. let's keep this asciidoc infra in place. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'