From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5base: remove libudev dependency from kms
Date: Tue, 6 Sep 2016 19:58:06 +0200 [thread overview]
Message-ID: <20160906195806.2e7e363a@gmx.net> (raw)
In-Reply-To: <20160820231525.GC5784@free.fr>
Hello Yann,
On Sun, 21 Aug 2016 01:15:25 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Peter, All,
>
> On 2016-08-20 21:09 +0200, Peter Seiderer spake thusly:
> > Use upstream patch [1]
>
> I'd say be carefull when backporting patches from upstream, especially
> since upstream has changed the license after the Qt-5.6 release.
>
> Backporting a patch in this case would risk propagating the new license.
>
Thanks for license change hint, will double check in future...
Hope it is no problem here because the same patch (despite my original
source link from 5.7 branch) is although available from the 5.6
branch ([3])...
Regards,
Peter
[3] https://code.qt.io/cgit/qt/qtbase.git/commit/config.tests/qpa/kms/kms.pro?h=5.6&id=72492735b7b7770808fcc9fe067e8f03fab827fc
> However, this is acceptable in this case, because this only touches the
> .pro file, which is part of the buildsystem.
>
> Regards,
> Yann E. MORIN.
>
> > Fixes [2]:
> >
> > KMS auto-detection... ()
> > Project ERROR: libudev development package not found
> > KMS disabled.
> > KMS support cannot be enabled due to functionality tests!
> > Turn on verbose messaging (-v) to ./configure to see the final report.
> > If you believe this message is in error you may use the continue
> > switch (-continue) to ./configure to continue.
> >
> > [1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
> > [2] http://autobuild.buildroot.net/results/063/063859ad460552dd7c101115500b7845045a134f
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > ...07-Remove-libudev-dependency-from-kms.pro.patch | 33 ++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644 package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
> >
> > diff --git a/package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch b/package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
> > new file mode 100644
> > index 0000000..7ecbcd0
> > --- /dev/null
> > +++ b/package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
> > @@ -0,0 +1,33 @@
> > +From 0f1b4bb65abe0e36e9e4b9813e45192223509de8 Mon Sep 17 00:00:00 2001
> > +From: Ralf Nolden <nolden@kde.org>
> > +Date: Tue, 17 May 2016 12:57:17 +0200
> > +Subject: [PATCH] Remove libudev dependency from kms.pro
> > +
> > +To compile the kms qpa plugin, only libdrm is needed.
> > +Remove the libudev dependency for the compile check to enable
> > +building of the qpa plugin on platforms where libudev is not present
> > +such as BSD systems (but where KMS works)
> > +
> > +Change-Id: Icd0be70a8949578a6158d523428706890a9674eb
> > +Reviewed-by: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
> > +Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
> > +
> > +Upstream: https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > +---
> > + config.tests/qpa/kms/kms.pro | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/config.tests/qpa/kms/kms.pro b/config.tests/qpa/kms/kms.pro
> > +index 1fb7367..5147bc8 100644
> > +--- a/config.tests/qpa/kms/kms.pro
> > ++++ b/config.tests/qpa/kms/kms.pro
> > +@@ -1,4 +1,4 @@
> > + SOURCES = kms.cpp
> > + CONFIG += link_pkgconfig
> > +-PKGCONFIG += libdrm libudev
> > ++PKGCONFIG += libdrm
> > + CONFIG -= qt
> > +--
> > +2.8.1
> > +
> > --
> > 2.8.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
prev parent reply other threads:[~2016-09-06 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 19:09 [Buildroot] [PATCH v1] qt5base: remove libudev dependency from kms Peter Seiderer
2016-08-20 20:36 ` Thomas Petazzoni
2016-08-20 23:15 ` Yann E. MORIN
2016-09-06 17:58 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906195806.2e7e363a@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox