From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add new library: libpugixml
Date: Fri, 9 Sep 2016 14:14:11 +0200 [thread overview]
Message-ID: <20160909141411.45cf530d@free-electrons.com> (raw)
In-Reply-To: <20160906120739.hf6sacfuyopg5sud@skynet.be>
Hello,
On Tue, 6 Sep 2016 14:07:39 +0200, Theo Debrouwere wrote:
> > The readme.txt is good enough as a license file.
> >
> > > +LIBPUGIXML_INSTALL_STAGING = YES
> > > +
> > > +LIBPUGIXML_SUBDIR = scripts
> >
> > Hum, why?
>
> Is this about the SUBDIR option?
>
> The CMakeLists.txt file is in a subfolder called scripts,
> so, it seems that I need this? Is there another option/setting?
>
> Or should I add a comment about it?
>
> I'm not sure what you are asking?
What confused me is that in the latest version of pugixml (i.e master
branch), the CMakeLists.txt is directly at the root of the project:
https://github.com/zeux/pugixml
However, since you are packaging the 1.7 version, which is a bit older
than the master branch, the CMakeLists.txt is indeed inside the
scripts/ subdirectory:
https://github.com/zeux/pugixml/tree/v1.7
So, it makes complete sense to use the SUBDIR option in this case. It's
just that I was confused when looking at the Github repository, as I
was looking at the master branch.
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-09 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 21:08 [Buildroot] [PATCH] add new library: libpugixml Theo Debrouwere
2016-09-05 20:47 ` Samuel Martin
2016-09-05 21:30 ` Thomas Petazzoni
2016-09-06 12:07 ` Theo Debrouwere
2016-09-09 12:14 ` Thomas Petazzoni [this message]
2016-09-05 22:15 ` Arnout Vandecappelle
2016-09-07 15:21 ` [Buildroot] pugixml: new package Theo Debrouwere
2016-09-07 15:37 ` Theo Debrouwere
2016-09-07 15:37 ` [Buildroot] [PATCH] " Theo Debrouwere
2016-09-07 19:44 ` Peter Korsgaard
2016-09-11 21:08 ` Thomas Petazzoni
2016-09-11 21:56 ` Theo Debrouwere
2016-09-11 22:15 ` Arnout Vandecappelle
2016-09-12 6:47 ` Vlad Zakharov
2016-09-12 7:19 ` Thomas Petazzoni
2016-09-12 8:14 ` [Buildroot] [PATCH] package/pugixml: Fix CMakelists.txt cxx_long_long_type bug Theo Debrouwere
2016-09-12 9:34 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909141411.45cf530d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox