[Buildroot] [PATCH RFC] pkg-kconfig: support alternative .config location

[Eric Le Bihan <eric.le.bihan.dev@free.fr>]

Hi!

Le Sun, 11 Sep 2016 19:34:03 +0200,
"Yann E. MORIN" <yann.morin.1998@free.fr> a ?crit :

> On 2016-09-11 19:07 +0200, Eric Le Bihan spake thusly:
> > Kconfig clones, such as openconf used by xvisor [1], do not look
> > for .config at the root of the build directory, but in a
> > subdirectory (e.g. build/openconf).
> > 
> > This patch introduces a new Makefile variable named
> > $(2)_KCONFIG_BUILD_FILE, which defaults to $$($(2)_DIR)/.config and
> > can be overridden in the package Makefile.
> > 
> > This allows the use of the kconfig-package infrastructure with
> > packages relying on such clones.
> > 
> > [1] https://github.com/xvisor/xvisor/tree/master/tools/openconf
> > 
> > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> > ---
> >  package/pkg-kconfig.mk | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> > 
> > diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk
> > index b0f5178..82561de 100644
> > --- a/package/pkg-kconfig.mk
> > +++ b/package/pkg-kconfig.mk
> > @@ -36,6 +36,7 @@ $(2)_KCONFIG_EDITORS ?= menuconfig
> >  $(2)_KCONFIG_OPTS ?=
> >  $(2)_KCONFIG_FIXUP_CMDS ?=
> >  $(2)_KCONFIG_FRAGMENT_FILES ?=
> > +$(2)_KCONFIG_BUILD_FILE ?= $$($(2)_DIR)/.config  
> 
> I think it would be better to name the variable
> $(2)_KCONFIG_DOTCONFIG_FILE or maybe just $(2)_KCONFIG_DOTCONFIG.

OK.

> Otherwise, the rest of the patch is a mere search-and-replace, so
> looks pretty OK.
> 
> However, I don't see the point in having that in Buildroot without an
> actuall package that uses that. Do you plan in sending such a package
> (like xvisor)?

Yes, I will send a patch to add a xvisor package shortly.

Thanks for the review.

-- 
ELB