From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7] package/upmpdcli: use pkg-config for libupnpp
Date: Wed, 14 Sep 2016 14:05:04 +0200 [thread overview]
Message-ID: <20160914140504.1e07e618@free-electrons.com> (raw)
In-Reply-To: <20160914114146.3796-8-joerg.krause@embedded.rocks>
Hello,
On Wed, 14 Sep 2016 13:41:46 +0200, J?rg Krause wrote:
> Use the provided pkg-config file of libupnpp to get the correct LIBS.
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> package/upmpdcli/upmpdcli.mk | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
> index 3f521cf..208aa8f 100644
> --- a/package/upmpdcli/upmpdcli.mk
> +++ b/package/upmpdcli/upmpdcli.mk
> @@ -17,12 +17,10 @@ UPMPDCLI_AUTORECONF = YES
> ifeq ($(BR2_STATIC_LIBS),y)
> # Upmpdcli forgets to take the dependencies of libupnpp into
> # consideration, breaking static linking, so help it.
> -# Libupnpp unfortunately doesn't provide a .pc file, so manually
> -# handle the dependencies here.
> # The build system doesn't expand LIBS from the configure step, so
> # manually pass it to make.
> UPMPDCLI_MAKE_OPTS = \
> - LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs expat libcurl libupnp`"
> + LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libupnpp`"
> endif
Thanks to your patches, upmpdcli now uses pkg-config, so why do we
still need to pass this custom LIBS value ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-14 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 11:41 [Buildroot] [PATCH 0/7] package/upmpdcli: fix build issues Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 1/7] package/libupnpp: add patch to get pkg-config file Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 2/7] package/upmpdcli: requires GCC 4.7 Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 3/7] package/upmpdcli: fix missing dependencies Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 4/7] package/upmpdcli: add patch to fix jsoncpp detection Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 5/7] package/upmpdcli: add patch to fix unsafe header path Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 6/7] package/upmpdcli: add patch to fix include path of log Jörg Krause
2016-09-14 11:41 ` [Buildroot] [PATCH 7/7] package/upmpdcli: use pkg-config for libupnpp Jörg Krause
2016-09-14 12:05 ` Thomas Petazzoni [this message]
2016-09-14 12:46 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914140504.1e07e618@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox