From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra/pkg-kconfig: Be sure to reconfigure the package on foo-reconfigure
Date: Wed, 14 Sep 2016 20:38:16 +0200 [thread overview]
Message-ID: <20160914183816.GC5531@free.fr> (raw)
In-Reply-To: <20160914183205.GB5531@free.fr>
Thomas?, All,
On 2016-09-14 20:32 +0200, Yann E. MORIN spake thusly:
> On 2016-09-14 19:42 +0200, Thomas De Schampheleire spake thusly:
> > On Wed, Sep 14, 2016 at 11:01 AM, Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> wrote:
> > > Well, the question is not so much about "reconfigure", but about
> > > the configure step itself. Why isn't the configure step done inside
> > > <pkg>_CONFIGURE_CMDS ? If it had been done inside the
> > > <pkg>_CONFIGURE_CMDS, then those "hacks" to make reconfigure work
> > > would not be needed.
> > >
> > > I'm pretty sure that there's a solid reason for not doing the .config
> > > preparation inside <pkg>_CONFIGURE_CMDS, but it'd be great to remember
> > > why and document it somewhere :)
> >
> > I think the answer to this question is simple: one of the goals was to allow:
> >
> > 'make clean linux-menuconfig'
> >
> > without this step first building all dependencies of linux (which is
> > quite a lot).
> > If the kconfig configuration would be part of CONFIGURE_CMDS, then
> > we'd end up in that situation.
>
> Yes, that was the basis for our thinking at the time.
>
> Yet, maybe we could just move the call to the $(2)_REGEN_DOT_CONFIG
I meant: $(2)_FIXUP_DOT_CONFIG
> macro into the CONFIGURE_CMDS (or in a pre-configure hook).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-09-14 18:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 22:35 [Buildroot] [PATCH] infra/pkg-kconfig: Be sure to reconfigure the package on foo-reconfigure Yann E. MORIN
2016-09-13 22:59 ` Vivien Didelot
2016-09-13 23:29 ` Arnout Vandecappelle
2016-09-14 7:27 ` Thomas De Schampheleire
2016-09-14 9:01 ` Thomas Petazzoni
2016-09-14 17:42 ` Thomas De Schampheleire
2016-09-14 18:32 ` Yann E. MORIN
2016-09-14 18:38 ` Yann E. MORIN [this message]
2016-09-16 17:05 ` Thomas Petazzoni
2016-09-16 17:05 ` Thomas Petazzoni
2016-09-16 17:17 ` Yann E. MORIN
2016-09-16 17:56 ` Yann E. MORIN
2016-09-16 19:02 ` Yann E. MORIN
2016-09-17 12:42 ` Thomas Petazzoni
2016-09-17 12:53 ` Yann E. MORIN
2016-09-17 13:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914183816.GC5531@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox