From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] core: distclean is a noconfig target
Date: Sat, 17 Sep 2016 16:21:18 +0200 [thread overview]
Message-ID: <20160917162118.6b04b97d@free-electrons.com> (raw)
In-Reply-To: <1473602146-2675-1-git-send-email-yann.morin.1998@free.fr>
Hello,
On Sun, 11 Sep 2016 15:55:46 +0200, Yann E. MORIN wrote:
> When the .config contains invalid configuration *(e.g. two providers for
> a same virtual package), it is not possible to run "make distclean"
> because the .config file is sourced and packages interpreted in this
> case.
>
> Add distclean to the noconfig list, so that we can run it in all cases.
>
> However, this meand that DL_DIR is no longer set, and thus the default
> download location never removed. We fix that by always removing the
> download location, so that if it is the one configured we still remove
> it (no change) and if it is not the one configured, we remove an
> non-existing location and leave the user's location intact (no change
> either).
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> ---
> Changes v1 -> v2:
> - don't forget to remove the default download location (Thomas)
> - typoes (Thomas)
> ---
> Makefile | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-09-17 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 13:55 [Buildroot] [PATCHv2] core: distclean is a noconfig target Yann E. MORIN
2016-09-17 14:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917162118.6b04b97d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox