Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] boot/uboot: add missing SPL build dependency
Date: Sat, 17 Sep 2016 19:35:24 +0200	[thread overview]
Message-ID: <20160917193524.3dd6f8a1@free-electrons.com> (raw)
In-Reply-To: <706220f2-ed95-8a00-8a40-2c818636ac63@jikos.cz>

Hello,

On Sat, 3 Sep 2016 17:11:21 +0200, Petr Kulhavy wrote:

> > On 01-09-16 16:51, Petr Kulhavy wrote:  
> >> If SPL installation is selected make does not always build the SPL binary.  
> >   Please give a concrete example of this so people can verify.  
> 
> It doesn't work with the iMX "SPL" target.

I believe that if we invoke "make all", it will solve your problem as
well. What the SPL target does is:

SPL: spl/u-boot-spl.bin FORCE

And what make all does is:

all:            $(ALL-y)
ALL-$(CONFIG_SPL) += spl/u-boot-spl.bin

So as soon as CONFIG_SPL=y in the U-Boot configuration, the SPL will be
built if we do "make all". So I suggest that we do:

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 7379a4d..d0dbf6a 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -68,7 +68,7 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_IMG),y)
 UBOOT_BINS += u-boot-dtb.img
-UBOOT_MAKE_TARGET += all u-boot-dtb.img
+UBOOT_MAKE_TARGET += u-boot-dtb.img
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_FORMAT_IMG),y)
@@ -179,7 +179,7 @@ endif # BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
 define UBOOT_BUILD_CMDS
        $(TARGET_CONFIGURE_OPTS)        \
                $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS)             \
-               $(UBOOT_MAKE_TARGET)
+               all $(UBOOT_MAKE_TARGET)
        $(if $(BR2_TARGET_UBOOT_FORMAT_SD),
                $(@D)/tools/mxsboot sd $(@D)/u-boot.sb $(@D)/u-boot.sd)
        $(if $(BR2_TARGET_UBOOT_FORMAT_NAND),

Petr, does this fix the problem for you? Arnout, what do you think?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-09-17 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 14:51 [Buildroot] boot/uboot: allow multiple target selection Petr Kulhavy
2016-09-01 14:51 ` [Buildroot] [PATCH 1/2] boot/uboot: add missing SPL build dependency Petr Kulhavy
2016-09-02  7:13   ` Arnout Vandecappelle
2016-09-02 12:41     ` Thomas Petazzoni
2016-09-03 15:11     ` Petr Kulhavy
2016-09-17 17:35       ` Thomas Petazzoni [this message]
2016-09-01 14:51 ` [Buildroot] [PATCH 2/2] boot/uboot: allow to build multiple Uboot images Petr Kulhavy
2016-09-02  7:13   ` Arnout Vandecappelle
2016-09-02 10:53     ` Petr Kulhavy
2016-09-02 18:50       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160917193524.3dd6f8a1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox