From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 v3] toolchain/wrapper: display options leading to a paranoid failure
Date: Sun, 18 Sep 2016 16:13:59 +0200 [thread overview]
Message-ID: <20160918161359.0b5121c2@free-electrons.com> (raw)
In-Reply-To: <bc84e6b73e8ed3767bfeb120b614dff3818770e7.1472485693.git.yann.morin.1998@free.fr>
Hello,
On Mon, 29 Aug 2016 17:53:58 +0200, Yann E. MORIN wrote:
> Current, we only display the path that causes the paranoid failure. This
> is sufficient, as we can fail only for -I and -L options, and it is thus
> easy to infer from the path, which option is the culprit.
>
> However, we're soon to add a new test for the -isystem option, and then
> when a failure occurs, we would not know whether it was because of -I or
> -isystem. Being able to differentiate both can be hugely useful to
> track down the root cause for the unsafe path.
>
> Add two new arguments to the check_unsafe_path() function: one with the
> current-or-previous argument, one to specify whether it has the path in
> it or not. Print that in the error message, instead of just the path.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
>
> ---
> ---
> Changes v2 -> v3:
> - invert test to gain one indentation level (Thomas)
> - remove stray variables from v1 (Thomas)
> - add doc to the function (Thomas)
> - add a comment about the "' '" trick (Thomas)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-18 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 15:53 [Buildroot] [PATCH 0/2 v3] toolchain/wrapper: add more paranoid checks (branch yem/wrapper) Yann E. MORIN
2016-08-29 15:53 ` [Buildroot] [PATCH 1/2 v3] toolchain/wrapper: display options leading to a paranoid failure Yann E. MORIN
2016-09-18 14:13 ` Thomas Petazzoni [this message]
2016-08-29 15:53 ` [Buildroot] [PATCH 2/2 v3] toolchain/wrapper: extend paranoid check to -isystem Yann E. MORIN
2016-09-18 14:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918161359.0b5121c2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox