From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] python-pyqt5: new package
Date: Tue, 20 Sep 2016 21:14:56 +0200 [thread overview]
Message-ID: <20160920211456.7dc36850@free-electrons.com> (raw)
In-Reply-To: <20160823092606.1462-1-develop@manuel-voegele.de>
Hello,
I've applied your patch, after doing just a small change to it, see
below.
On Tue, 23 Aug 2016 11:26:06 +0200, Manuel V?gele wrote:
> new file mode 100644
> index 0000000..98c709e
> --- /dev/null
> +++ b/package/python-pyqt5/Config.in
> @@ -0,0 +1,17 @@
> +comment "python-pyqt5 needs a toolchain w/ wchar, NPTL, C++, dynamic library"
> + depends on !BR2_PACKAGE_QT
This line is unrelated (mentions Qt, while this package is for Qt5),
and in fact not needed: this package is *selecting* Qt5, so there is
no need to take into account a Qt dependency here.
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
This line is intended with spaces, while it should have been intended
with a tab. Also, it was too long, so I've split the line.
I've fixed those minor details and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-20 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:42 [Buildroot] [PATCH 0/2] PyQt5 package Manuel Vögele
2016-08-19 13:42 ` [Buildroot] [PATCH 1/2] python-sip: allow package to be built using Qt5 Manuel Vögele
2016-08-19 13:58 ` Thomas Petazzoni
2016-08-19 13:42 ` [Buildroot] [PATCH 2/2] python-pyqt5: new package Manuel Vögele
2016-08-19 14:07 ` Thomas Petazzoni
2016-08-19 14:40 ` Manuel Vögele
2016-08-19 14:48 ` Thomas Petazzoni
2016-08-23 9:26 ` [Buildroot] [PATCH v2] " Manuel Vögele
2016-09-20 19:14 ` Thomas Petazzoni [this message]
2016-09-22 20:54 ` Arnout Vandecappelle
2016-09-27 14:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920211456.7dc36850@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox