From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-tools: don; t register each tools twice
Date: Fri, 23 Sep 2016 08:09:23 +0200 [thread overview]
Message-ID: <20160923080923.77335af4@free-electrons.com> (raw)
In-Reply-To: <1474561686-22804-1-git-send-email-yann.morin.1998@free.fr>
Hello,
On Thu, 22 Sep 2016 18:28:06 +0200, Yann E. MORIN wrote:
> Because each tool's individual .mk files are included from the top-level
> Makefile and we also include them from linux-tools.mk, they get
> registered twice, and thus built twice, and thus installed twice.
>
> We did included them from linux-tools.mk to guarantee they would be
> included early and each tool had a chance to register itself before we
> were to construct the build and install hooks.
>
> However, the ordering is _currently_ guaranteed, in the C locale by the
> files names, which we anyway sort using make's $(sort) function, which
> always sorts in the C locale.
>
> Beware if we are to ever rename thos files in the future...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/linux-tools/linux-tools.mk | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
Applied to master after fixing minor typos here and there. Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-09-23 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 16:28 [Buildroot] [PATCH] package/linux-tools: don; t register each tools twice Yann E. MORIN
2016-09-23 6:09 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923080923.77335af4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox