From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst1-imx: add menuconfig to select each plugin individually
Date: Fri, 23 Sep 2016 15:13:06 +0200 [thread overview]
Message-ID: <20160923151306.1fd4e4c7@free-electrons.com> (raw)
In-Reply-To: <20160923125835.mr63ylhk25qb3gt2@t450s.lan>
Hello,
On Fri, 23 Sep 2016 14:58:35 +0200, Gary Bisson wrote:
> What about we stick with the depends for now?
It's fine for me.
> My V2 will take care of the dependencies inside the 'ifeq' statements in
> gst1-imx.mk. BTW, doing it as suggested kind of makes the code redundant
> since several plugins might have the same dependency, like:
>
> ifeq ($(BR2_PACKAGE_GST1_IMX_MP3ENCODER),y)
> # There's no --enable-mp3encoder option
> GST1_IMX_DEPENDENCIES += imx-codec
> else
> GST1_IMX_CONF_OPTS += --disable-mp3encoder
> endif
>
> ifeq ($(BR2_PACKAGE_GST1_IMX_UNIAUDIODEC),y)
> # There's no --enable-uniaudiodec option
> GST1_IMX_DEPENDENCIES += imx-codec
> else
> GST1_IMX_CONF_OPTS += --disable-uniaudiodec
> endif
>
> Is that ok? I know it doesn't bring any issue, just look a little
> redundant.
If only a single dependency is needed for those codecs, is it really
necessary to have different options to enable/disable them? How much
space do they take each?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-23 13:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 13:10 [Buildroot] [PATCH] gst1-imx: add menuconfig to select each plugin individually Gary Bisson
2016-09-20 19:04 ` Thomas Petazzoni
2016-09-20 22:43 ` Gary Bisson
2016-09-21 4:02 ` Thomas Petazzoni
2016-09-21 8:32 ` Gary Bisson
2016-09-21 9:03 ` Thomas Petazzoni
2016-09-22 21:51 ` Arnout Vandecappelle
2016-09-23 12:58 ` Gary Bisson
2016-09-23 13:13 ` Thomas Petazzoni [this message]
2016-09-23 13:40 ` Gary Bisson
2016-09-23 14:25 ` Thomas Petazzoni
2016-09-23 14:29 ` Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923151306.1fd4e4c7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox