Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] i2c-tools: install devt headers to staging dir
Date: Sat, 24 Sep 2016 16:18:10 +0200	[thread overview]
Message-ID: <20160924161810.09ee4fa5@free-electrons.com> (raw)
In-Reply-To: <1474639604-23866-1-git-send-email-julien.boibessot@free.fr>

Hello,

On Fri, 23 Sep 2016 16:06:44 +0200, julien.boibessot at free.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> 
> On debian (and maybe other distribs), there is a package named libi2c-dev
> that install a useful header from i2c-tools (for the one wanting to write
> I2C applications). See https://packages.debian.org/fr/wheezy/libi2c-dev.
> Do the same in Buildroot. Note that "install" target in i2c-tools Makefile
> would do the job, but BR installs i2c-tools's stuff manualy.
> 
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>

We already merged exactly the same patch in commit
ff673f9a22b1467878f1a117f2c6198e9683d5c7, and finally reverted it in
41711cfdeda6f5fd9b2531f538f3643854d7d3ea, with the following commit log:

commit 41711cfdeda6f5fd9b2531f538f3643854d7d3ea
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date:   Tue Mar 4 19:14:26 2014 +0100

    Revert "i2c-tools: Add i2c-dev.h to staging directory for userspace i2c drivers."
    
    This reverts commit ff673f9a22b1467878f1a117f2c6198e9683d5c7, as the
    modified i2c-dev.h from i2c-tools has some definitions that conflict
    with the i2c.h from the kernel headers. This means that a userspace
    program or library that includes both will fail to build, as is the
    case with libsoc.
    
    Fixes:
    
      http://autobuild.buildroot.org/results/1f4/1f451a338487a2a3c8a8f9b18540d41b90ee5aac/
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

So, if we are going to merge the same patch again, I'd like to be sure
that we won't fall into the exact same problems we had the previous
time. Could you check this?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-09-24 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 14:06 [Buildroot] [PATCH] i2c-tools: install devt headers to staging dir julien.boibessot at free.fr
2016-09-23 21:18 ` Arnout Vandecappelle
2016-09-26 20:19   ` Peter Korsgaard
2016-09-24 14:18 ` Thomas Petazzoni [this message]
2016-09-26  8:56   ` Julien Boibessot
2016-09-26 10:21     ` Arnout Vandecappelle
2016-09-26 20:17       ` Peter Korsgaard
2016-09-27  3:57         ` Baruch Siach
2016-09-28  8:24           ` Julien Boibessot
2016-09-28  8:52             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160924161810.09ee4fa5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox