From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opencv3: fix CMAKE_CXX_FLAGS
Date: Fri, 30 Sep 2016 10:10:34 +0200 [thread overview]
Message-ID: <20160930101034.4adf4d7e@free-electrons.com> (raw)
In-Reply-To: <CAMo8BfKyMkgwNih1MSGh+qrKtRMob4_j8neOi3v4e5xEaJKnBg@mail.gmail.com>
Hello,
On Thu, 29 Sep 2016 09:14:41 -0700, Max Filippov wrote:
> > There is something fishy going on here. Indeed,
> > support/misc/toolchainfile.cmake.in contains:
> >
> > set(CMAKE_CXX_FLAGS "@@TARGET_CXXFLAGS@@ ${CMAKE_CXX_FLAGS}" CACHE STRING "Buildroot CXXFLAGS")
> >
> > So it should normally always prefix CMAKE_CXX_FLAGS with
> > TARGET_CXXFLAGS. Can you check the toolchain.cmake file that gets
> > generated during your build? Does it contains the Xtensa specific
> > CXXFLAGS ?
>
> Yes, it does.
So if it does, why is your patch necessary? I'm not following here.
Do you mean that the Xtensa-specific flags are present in the
toolchain.cmake file, but are in the end not used during the build ?
> opencv2 which has similar cmake build system but doesn't pass
> -DCMAKE_CXX_FLAGS builds correctly.
OK.
Samuel, can you advise here?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-30 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 18:40 [Buildroot] [PATCH] package/opencv3: fix CMAKE_CXX_FLAGS Max Filippov
2016-09-29 9:27 ` Thomas Petazzoni
2016-09-29 16:14 ` Max Filippov
2016-09-30 8:10 ` Thomas Petazzoni [this message]
2016-09-30 16:32 ` Max Filippov
2016-09-30 22:07 ` Samuel Martin
2016-10-16 13:54 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930101034.4adf4d7e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox