From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/linux-tools: add gpio
Date: Tue, 4 Oct 2016 17:42:54 +0200 [thread overview]
Message-ID: <20161004154254.GA3806@free.fr> (raw)
In-Reply-To: <3c84132d-9e2b-5e9c-83bb-b43e8acdf1db@grinn-global.com>
Marcin, All,
On 2016-10-04 08:53 +0200, Marcin Niestroj spake thusly:
> On 03.10.2016 19:06, Yann E. MORIN wrote:
> >On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
> >>Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
[--SNIP--]
> >>diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
> >>new file mode 100644
> >>index 0000000..db0094a
> >>--- /dev/null
> >>+++ b/package/linux-tools/linux-tool-gpio.mk
> >>@@ -0,0 +1,28 @@
> >>+################################################################################
> >>+#
> >>+# gpio
> >>+#
> >>+################################################################################
> >>+
> >>+LINUX_TOOLS += gpio
> >>+
> >>+GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
> >
> >Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
> >
> > GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
> >
> >LINUX_MAKE_FLAGS shall contain all the required variable definitions
> >needed to build for the target.
> >
> >Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
> >selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
> >there is a good reason not to.
> >
> >This would allow use to easily update the compile options/variables.
>
> I just did it similar to cpupower package. But using LINUX_MAKE_FLAGS
> looks like a better option.
>
> What about specifying also DESTDIR together:
> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) DESTDIR=$(TARGET_DIR)
> so we can simplify GPIO_INSTALL_TARGET_CMDS?
> This would be similar to perf package.
No, please specify DESTDIR only at install time.
Regards,
Yann E. MORIN.
> >(Sorry, I forgot to point that out in the previous review...)
> >
> >Regards,
> >Yann E. MORIN.
> >
> >>+define GPIO_BUILD_CMDS
> >>+ $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
> >>+ echo "Your kernel version is too old and does not have the gpio tools." ; \
> >>+ echo "At least kernel 4.8 must be used." ; \
> >>+ exit 1 ; \
> >>+ fi
> >>+
> >>+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> >>+ $(GPIO_MAKE_OPTS) \
> >>+ gpio
> >>+endef
> >>+
> >>+define GPIO_INSTALL_TARGET_CMDS
> >>+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> >>+ $(GPIO_MAKE_OPTS) \
> >>+ DESTDIR=$(TARGET_DIR) \
> >>+ gpio_install
> >>+endef
> >>--
> >>2.10.0
> >>
> >>_______________________________________________
> >>buildroot mailing list
> >>buildroot at busybox.net
> >>http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
> --
> Marcin Niestroj
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-10-04 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 12:25 [Buildroot] [PATCH v3] package/linux-tools: add gpio Marcin Niestroj
2016-10-03 17:06 ` Yann E. MORIN
2016-10-04 6:53 ` Marcin Niestroj
2016-10-04 15:42 ` Yann E. MORIN [this message]
2016-10-04 22:05 ` Arnout Vandecappelle
2016-10-05 6:38 ` Marcin Niestroj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004154254.GA3806@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox