Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/python-mwclient: new package
Date: Fri, 7 Oct 2016 15:32:47 +0200	[thread overview]
Message-ID: <20161007153247.35bd422a@free-electrons.com> (raw)
In-Reply-To: <20161006044858.27768-4-bernd.kuhls@t-online.de>

Hello,

On Thu,  6 Oct 2016 06:48:57 +0200, Bernd Kuhls wrote:

> +++ b/package/python-mwclient/python-mwclient.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-mwclient
> +#
> +################################################################################
> +
> +PYTHON_MWCLIENT_VERSION = 0.8.1
> +PYTHON_MWCLIENT_SOURCE = mwclient-$(PYTHON_MWCLIENT_VERSION).tar.gz
> +PYTHON_MWCLIENT_SITE = https://pypi.python.org/packages/19/79/481b288a497f625ee8f76141ff3472d81428b1f14b7155a28a63a3247197
> +PYTHON_MWCLIENT_SETUP_TYPE = setuptools
> +PYTHON_MWCLIENT_LICENSE = MIT
> +PYTHON_MWCLIENT_DEPENDENCIES = python-requests python-six

Well, your Config.in says they are runtime dependencies, but you use
them as build-time dependencies. This doesn't look good.

Please use LICENSE.md as the license file.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-10-07 13:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  4:48 [Buildroot] [PATCH 1/5] package/python-couchdb: new package Bernd Kuhls
2016-10-06  4:48 ` [Buildroot] [PATCH 2/5] package/python-futures: " Bernd Kuhls
2016-10-07 13:31   ` Thomas Petazzoni
2016-10-06  4:48 ` [Buildroot] [PATCH 3/5] package/python-pylru: " Bernd Kuhls
2016-10-07 13:31   ` Thomas Petazzoni
2016-10-06  4:48 ` [Buildroot] [PATCH 4/5] package/python-mwclient: " Bernd Kuhls
2016-10-07 13:32   ` Thomas Petazzoni [this message]
2016-10-06  4:48 ` [Buildroot] [PATCH 5/5] package/python-mwscrape: " Bernd Kuhls
2016-10-07 13:33   ` Thomas Petazzoni
2016-10-07 13:30 ` [Buildroot] [PATCH 1/5] package/python-couchdb: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007153247.35bd422a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox